Feature/david/remove sticky search deprecated jobs #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmstein
requested review from
CDRussell,
cmonfortep,
marcosholgado and
subsymbolic
as code owners
subsymbolic
reviewed
Apr 28, 2020
| } | ||
|
|
||
| @Test | ||
| fun allDeprecatedWorkIsCancelledUponStart() = runBlocking<Unit> { |
Contributor
There was a problem hiding this comment.
Our tests names follow a when<condition>Then<expectedResult> naming convention. This test doesn't seem to validate what the name suggest e.g if I delete the new call to cancelAllUnnecessaryWork this test still passes.
Contributor
Author
There was a problem hiding this comment.
good catch, I will modify the test to enqueue a few deprecated jobs!
Contributor
Author
There was a problem hiding this comment.
and change the name of course
Member
|
@malmstein, can you advise where in the DB to look for the tag name? I can't find it, even when inspecting the DB on |
… what's supposed to do
CDRussell
approved these changes
Apr 29, 2020
malmstein
deleted the
feature/david/remove_sticky_search_deprecated_jobs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1157893581871903/1171986548569356
Description:
As part of the remove of the Sticky Search Experiment we also want to make sure that if there was a job already scheduled it's properly removed from the WorkManager
This PR adds that functionality, making it easier in the future to remove old jobs.
Steps to test this PR:
CONTINUOUS_APP_USE_REQUEST_TAGis no longer present in the WorkManager