add catch to exception handler #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDRussell
requested review from
cmonfortep,
malmstein,
marcosholgado and
subsymbolic
as code owners
marcosholgado
approved these changes
Apr 28, 2020
Contributor
marcosholgado
left a comment
marcosholgado
left a comment
There was a problem hiding this comment.
Good job! Tested with and without the try catch and working as expect, without it loops indefinitely reporting new crashes and with the try catch it doesn't.
CDRussell
added a commit
that referenced
this pull request
Apr 28, 2020
* Add try/catch handling to uncaught exception handler * Add try/catch to exception handler (cherry picked from commit 8c7b763)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/608920331025315/1173206265028385
Tech Design URL:
CC:
Description:
Add
try/catchto uncaught exception handler. We've observed scenarios where the exception handling can itself throw an exception which would cause an infinite loop.Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template