Fix issue in activity_user_survey.xml #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john2020star
requested review from
CDRussell,
cmonfortep,
malmstein,
marcosholgado and
subsymbolic
as code owners
Contributor
|
We don't have any surveys running right now but I tested this with some dummy data and can confirm that the progress bar wasn't displayed on API 21 and is fixed by this change as per the gif.
|
Contributor
|
Thanks for catching this and submitting a PR @john2020star! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found there is a issue in activity_user_survey.xml, you did not set
android:indeterminateTintMode="src_in", which can cause inconsistent color of ProgressBar in API Level 21. This pull request help you fix it.Thanks and wish the information is useful for you.