Skip to content

Conversation

@marcosholgado
Copy link
Contributor

@marcosholgado marcosholgado commented Apr 29, 2020

Task/Issue URL: https://app.asana.com/0/414730916066338/1172744955314993
Tech Design URL:
CC:

Description:
This PR adds two new fields to the UncaughtException table (version and timestamp).

Steps to test this PR:

Update from previous version:

  1. Build the app from develop.
  2. Create a crash.
  3. Without re-launching the app again build the app from this branch.
  4. Launch the app
  5. Make sure the UncaughtException table is empty.
  6. Make sure the previous crash recorder is not sent (filter the log by Sent pixel with params:)

Crash on new version

  1. Launch the app and create a crash.
  2. Without re-launching the app make sure the UncaughtException table has the exception recorded including the timestamp and version.
  3. Re-launch the app.
  4. Make sure the pixel is sent (filter the log by Sent pixel with params:) and the timestamp parameter is set to UTC.

Internal references:

Software Engineering Expectations
Technical Design Template

@marcosholgado marcosholgado merged commit 38ccdcb into develop Apr 29, 2020
@marcosholgado marcosholgado deleted the feature/marcos/add_version_and_timestamp_to_crashes branch April 29, 2020 14:59
CDRussell pushed a commit that referenced this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants