Android: Authentication popup shown in the context of previous website #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If dialog dismissed by activity, cancel authentication
cmonfortep
requested review from
CDRussell,
malmstein,
marcosholgado and
subsymbolic
as code owners
Contributor
|
@cmonfortep thanks for fixing this, I'll review it today. |
subsymbolic
approved these changes
May 11, 2020
Contributor
subsymbolic
left a comment
subsymbolic
left a comment
There was a problem hiding this comment.
A couple of small suggestion otherwise this LGTM. Merge when you're ready.
| loadUrl(url = "http://example.com", isBrowserShowing = true) | ||
| testee.requiresAuthentication(authenticationRequest) | ||
|
|
||
| assertEquals("http://example.com", omnibarViewState().omnibarText) |
Contributor
There was a problem hiding this comment.
Since the opposite test (the next one) checks that that the HideWebViewContent command is sent does it make sense to check that the HideWebViewContent command is not sent here?
|
|
||
| override fun onDismiss(dialog: DialogInterface) { | ||
| super.onDismiss(dialog) | ||
| //if listener is not null, user didn't press any button. We proceed to cancel. |
Contributor
There was a problem hiding this comment.
Can we make this self documenting? We could add a boolean method called didUserCompleteAuthentication or something similar and that would let us delete this comment.
Contributor
Author
There was a problem hiding this comment.
yeah, I didn't think about that. I like the idea of self documenting 💯
# Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1173393687766921/f
Tech Design URL:
CC:
Description:
When authentication popup is show, previous website is still loaded in the background. This could add some confusion to users if the popup is triggered by an non related website.
Update the URL and hide web content if authentication popup is triggered by a host different to the website currently being displayed. Display content again when dialog dismissed.
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template