Android: Site-level "fireproof" feature to preserve logins #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create new database table to persist sites where cookies should be preserved * Removed divider from bookmarks list * bookmarks title show in single line * background favicon compatible with dark theme * introduce fireproof site option menu * Fireproof option menu reacts to database state. * Fireproof website screen created
* Implement logic to remove cookies preserving the ones related to fireproof website. - Try to directly remove cookies from WebView database, preserving the ones with hosts related to a fireproof website - If process fails, fallback to remove all the cookies to avoid any leak - Send pixels in the following scenarios: - database path not found - database can't be opened - delete query fails - database corruption
* Empty state for fireproof websites screen * Feature pixels - User clicks on "fireproof a website" - User undo "fireproof website" action (confirmation snackbar after fireproffing a website) - User removed a website from "fireproof websites"
# Conflicts: # app/schemas/com.duckduckgo.app.global.db.AppDatabase/20.json # app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt # app/src/androidTest/java/com/duckduckgo/app/global/db/AppDatabaseTest.kt # app/src/main/java/com/duckduckgo/app/bookmarks/ui/BookmarksActivity.kt # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt # app/src/main/java/com/duckduckgo/app/global/db/AppDatabase.kt # app/src/main/java/com/duckduckgo/app/settings/SettingsActivity.kt # app/src/main/java/com/duckduckgo/app/settings/SettingsViewModel.kt # app/src/main/res/drawable/ic_overflow.xml # app/src/main/res/drawable/ic_overflow_24dp.xml # app/src/main/res/drawable/ic_overflow_bookmarks_24dp.xml # app/src/main/res/layout/layout_browser_bottom_navigation_bar.xml # app/src/main/res/layout/layout_tabs_bottom_navigation_bar.xml # app/src/main/res/layout/view_bookmark_entry.xml # app/src/main/res/values/attrs.xml # app/src/main/res/values/string-untranslated.xml
CDRussell
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1175609299816961/f
Tech Design URL:
CC:
Description:
This is a feature branch that will merge into develop following previous PRs:
#796
#808
#810
Steps to test this PR:
Listing the most important tests to validate the feature works. For more concrete testing, please go to each PR description.
Test 1
Test 2
Test 3
Test 4
Test 5
Additional test:
Internal references:
Software Engineering Expectations
Technical Design Template