Feature/craig/lint checking

app/build.gradle

@@ -4,6 +4,7 @@ apply plugin: 'kotlin-android'
 apply plugin: 'kotlin-android-extensions'
 apply plugin: 'kotlin-kapt'
 apply from: '../versioning.gradle'
+apply from: "$rootDir/ktlint.gradle"
 
 ext {
     USE_ORCHESTRATOR = project.hasProperty('orchestrator') ? project.property('orchestrator') : false

app/src/androidTest/java/com/duckduckgo/app/CoroutineTestRule.kt

@@ -50,4 +50,4 @@ class CoroutineTestRule(val testDispatcher: TestCoroutineDispatcher = TestCorout
 @ExperimentalCoroutinesApi
 fun CoroutineTestRule.runBlocking(block: suspend () -> Unit) = this.testDispatcher.runBlockingTest {
     block()
-}
+}

app/src/androidTest/java/com/duckduckgo/app/FileUtilities.kt

@@ -26,4 +26,4 @@ object FileUtilities {
         return javaClass.classLoader!!.getResource(resourceName).openStream().bufferedReader()
     }
 
-}
+}

app/src/androidTest/java/com/duckduckgo/app/InstantSchedulersRule.kt

@@ -16,15 +16,13 @@
 
 package com.duckduckgo.app
 
-
 import io.reactivex.android.plugins.RxAndroidPlugins
 import io.reactivex.plugins.RxJavaPlugins
 import io.reactivex.schedulers.Schedulers
 import org.junit.rules.TestRule
 import org.junit.runner.Description
 import org.junit.runners.model.Statement
 
-
 class InstantSchedulersRule : TestRule {
 
     override fun apply(base: Statement, description: Description): Statement {
@@ -53,4 +51,4 @@ class InstantSchedulersRule : TestRule {
         }
     }
 
-}
+}

app/src/androidTest/java/com/duckduckgo/app/TestApplication.kt

@@ -19,7 +19,6 @@ package com.duckduckgo.app
 import com.duckduckgo.app.di.DaggerTestAppComponent
 import com.duckduckgo.app.global.DuckDuckGoApplication
 
-
 class TestApplication : DuckDuckGoApplication() {
 
     /**
@@ -34,4 +33,4 @@ class TestApplication : DuckDuckGoApplication() {
             .build()
         daggerAppComponent.inject(this)
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/TestExtensions.kt

@@ -44,4 +44,4 @@ fun getApp(): TestApplication {
 
 fun getDaggerComponent(): TestAppComponent {
     return getApp().daggerAppComponent as TestAppComponent
-}
+}

app/src/androidTest/java/com/duckduckgo/app/TestRunner.kt

@@ -20,10 +20,9 @@ import android.app.Application
 import android.content.Context
 import androidx.test.runner.AndroidJUnitRunner
 
-
 @Suppress("unused")
 class TestRunner : AndroidJUnitRunner() {
     override fun newApplication(cl: ClassLoader, className: String, context: Context): Application {
         return super.newApplication(cl, TestApplication::class.java.name, context)
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/autocomplete/api/AutoCompleteApiTest.kt

@@ -75,4 +75,4 @@ class AutoCompleteApiTest {
 
         assertSame("https://example.com", value.suggestions[0].phrase)
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/bookmarks/db/BookmarksDaoTest.kt

@@ -92,4 +92,4 @@ class BookmarksDaoTest {
         assertFalse(dao.hasBookmarks())
     }
 
-}
+}

app/src/androidTest/java/com/duckduckgo/app/bookmarks/ui/BookmarksViewModelTest.kt

@@ -101,4 +101,4 @@ class BookmarksViewModelTest {
         assertNotNull(captor.value)
         assertNotNull(captor.value.bookmarks)
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/brokensite/BrokenSiteDataTest.kt

@@ -116,4 +116,4 @@ class BrokenSiteDataTest {
     companion object {
         private const val SITE_URL = "foo.com"
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/BrowserChromeClientTest.kt

@@ -118,4 +118,4 @@ class BrowserChromeClientTest {
     }
 
     private class TestWebView(context: Context) : WebView(context)
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/BrowserViewModelTest.kt

@@ -166,4 +166,4 @@ class BrowserViewModelTest {
     companion object {
         const val TAB_ID = "TAB_ID"
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/BrowserWebViewClientTest.kt

@@ -131,4 +131,4 @@ class BrowserWebViewClientTest {
     companion object {
         const val EXAMPLE_URL = "example.com"
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/DuckDuckGoRequestRewriterTest.kt

@@ -79,4 +79,4 @@ class DuckDuckGoRequestRewriterTest {
         assertFalse(uri.queryParameterNames.contains(ParamKey.ATB))
     }
 
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/DuckDuckGoUrlDetectorTest.kt

@@ -71,4 +71,3 @@ class DuckDuckGoUrlDetectorTest {
         assertFalse(testee.isDuckDuckGoQueryUrl("https://example.com?q=test%20search"))
     }
 }
-

app/src/androidTest/java/com/duckduckgo/app/browser/DuckDuckGoWebViewTest.kt

@@ -34,4 +34,4 @@ class DuckDuckGoWebViewTest {
             assertFalse(testee.settings.safeBrowsingEnabled)
         }
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/EmptyNavigationStateTest.kt

@@ -53,4 +53,4 @@ class EmptyNavigationStateTest {
             hasNavigationHistory = true
         )
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/QueryUrlConverterTest.kt

@@ -82,4 +82,4 @@ class QueryUrlConverterTest {
         assertNotNull(encodedQuery)
         assertTrue("Query string doesn't match. Expected `q=$query` somewhere in query ${uri.encodedQuery}", encodedQuery!!.contains("q=$query"))
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/SpecialUrlDetectorImplTest.kt

@@ -195,4 +195,4 @@ class SpecialUrlDetectorImplTest {
         val charList: List<Char> = ('a'..'z') + ('0'..'9')
         return List(length) { charList.random() }.joinToString("")
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/WebViewDataManagerTest.kt

@@ -121,4 +121,4 @@ class WebViewDataManagerTest {
             clearedFormData = true
         }
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/WebViewLongPressHandlerTest.kt

@@ -181,4 +181,4 @@ class WebViewLongPressHandlerTest {
         verify(mockMenu, never()).add(anyInt(), anyInt(), anyInt(), anyInt())
         verify(mockMenu, never()).add(anyInt(), anyInt(), anyInt(), anyString())
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/WebViewRequestInterceptorTest.kt

@@ -260,7 +260,6 @@ class WebViewRequestInterceptorTest {
         assertRequestCanContinueToLoad(response)
     }
 
-
     @Test
     fun whenRequestShouldBlockAndNoSurrogateThenCancellingResponseReturned() = runBlocking<Unit> {
         whenever(mockResourceSurrogates.get(any())).thenReturn(SurrogateResponse(responseAvailable = false))

app/src/androidTest/java/com/duckduckgo/app/browser/defaultbrowsing/DefaultBrowserObserverTest.kt

@@ -85,4 +85,4 @@ class DefaultBrowserObserverTest {
 
         verify(mockPixel).fire(Pixel.PixelName.DEFAULT_BROWSER_UNSET)
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/downloader/DataUriParserTest.kt

@@ -72,4 +72,4 @@ class DataUriParserTest {
         val filename = testee.generate("data:,AAAA") as ParsedDataUri
         assertFalse(filename.toString().contains("."))
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/filechooser/FileChooserIntentBuilderTest.kt

@@ -159,4 +159,4 @@ class FileChooserIntentBuilderTest {
         val actual = flags and expectedFlag
         return expectedFlag == actual
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/navigation/WebViewBackForwardListSafeExtractorTest.kt

@@ -49,4 +49,4 @@ class TestWebViewThrowsNullPointerException(context: Context) : WebView(context)
     override fun copyBackForwardList(): WebBackForwardList {
         throw NullPointerException("Deliberate")
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/rating/db/AppEnjoymentDatabaseRepositoryTest.kt

@@ -42,7 +42,6 @@ class AppEnjoymentDatabaseRepositoryTest {
     private lateinit var database: AppDatabase
     private lateinit var dao: AppEnjoymentDao
 
-
     @Before
     fun setup() {
         database = Room.inMemoryDatabaseBuilder(InstrumentationRegistry.getInstrumentation().targetContext, AppDatabase::class.java)
@@ -127,4 +126,4 @@ class AppEnjoymentDatabaseRepositoryTest {
         private val FIRST_PROMPT = PromptCount(1)
         private val SECOND_PROMPT = PromptCount(2)
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/tabpreview/FileBasedWebViewPreviewPersisterTest.kt

@@ -108,4 +108,4 @@ class FileBasedWebViewPreviewPersisterTest {
     private fun verifyTabPreviewDirectoryUse(path: String) {
         assertTrue(path.contains("/${FileBasedWebViewPreviewPersister.TAB_PREVIEW_DIRECTORY}"))
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/browser/useragent/UserAgentProviderTest.kt

@@ -70,4 +70,4 @@ class UserAgentProviderTest {
         val actual = testee.getUserAgent(desktopSiteRequested = false)
         assertTrue(MOBILE_UA_REGEX_MISSING_APPLE_WEBKIT_DETAILS.matches(actual))
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/cta/db/DismissedCtaDaoTest.kt

@@ -53,4 +53,4 @@ class DismissedCtaDaoTest {
         dao.insert(DismissedCta(CtaId.ADD_WIDGET))
         assertTrue(dao.exists(CtaId.ADD_WIDGET))
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/cta/ui/CtaTest.kt

@@ -100,7 +100,6 @@ class CtaTest {
         assertTrue(testee.pixelShownParameters().isEmpty())
     }
 
-
     @Test
     fun whenCtaIsAddWidgetInstructionsReturnEmptyOkParameters() {
         val testee = HomePanelCta.AddWidgetInstructions
@@ -350,4 +349,4 @@ class CtaTest {
         whenever(site.calculateGrades()).thenReturn(Site.SiteGrades(grade, improvedGrade))
         return site
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/cta/ui/CtaViewModelTest.kt

@@ -379,7 +379,6 @@ class CtaViewModelTest {
         assertTrue(value is DaxDialogCta.DaxSerpCta)
     }
 
-
     @Test
     fun whenRefreshCtaWhileBrowsingThenReturnNoSerpCta() = coroutineRule.runBlocking {
         givenDaxOnboardingActive()
@@ -431,7 +430,7 @@ class CtaViewModelTest {
         whenever(mockUserStageStore.getUserAppStage()).thenReturn(AppStage.DAX_ONBOARDING)
     }
 
-    private suspend fun givenDaxOnboardingCompleted() { 
+    private suspend fun givenDaxOnboardingCompleted() {
         whenever(mockUserStageStore.getUserAppStage()).thenReturn(AppStage.ESTABLISHED)
     }
 

app/src/androidTest/java/com/duckduckgo/app/di/StubAppConfigurationDownloadModule.kt

@@ -32,4 +32,4 @@ class StubAppConfigurationDownloadModule {
             }
         }
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/di/StubDatabaseModule.kt

@@ -23,7 +23,6 @@ import dagger.Module
 import dagger.Provides
 import javax.inject.Singleton
 
-
 @Module(includes = [DaoModule::class])
 class StubDatabaseModule {
 
@@ -34,4 +33,4 @@ class StubDatabaseModule {
             .allowMainThreadQueries()
             .build()
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/di/StubJobSchedulerModule.kt

@@ -62,4 +62,4 @@ class StubJobSchedulerModule {
     fun providesWorkScheduler(notificationScheduler: AndroidNotificationScheduler, jobCleaner: JobCleaner): WorkScheduler {
         return AndroidWorkScheduler(notificationScheduler, jobCleaner)
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/di/StubStatisticsModule.kt

@@ -83,4 +83,4 @@ class StubStatisticsModule {
     ): AtbInitializer {
         return AtbInitializer(statisticsDataStore, statisticsUpdater, appReferrerStateListener)
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/di/TestAppComponent.kt

@@ -85,4 +85,4 @@ interface TestAppComponent : AppComponent {
 
     @Named("api")
     fun retrofit(): Retrofit
-}
+}

app/src/androidTest/java/com/duckduckgo/app/feedback/ui/BrokenSiteViewModelTest.kt

@@ -180,4 +180,4 @@ class BrokenSiteViewModelTest {
         private const val message = "Feedback message"
     }
 
-}
+}

app/src/androidTest/java/com/duckduckgo/app/fire/AutomaticDataClearerTest.kt

@@ -517,11 +517,10 @@ class AutomaticDataClearerTest {
         }
     }
 
-
     @Test
     fun whenNotFreshAppLaunchAndIconNotChangedThenShouldClear() = runBlocking<Unit> {
         val isFreshAppLaunch = false
-        
+
         configureAppIconNotChanged()
         configureAppNotUsedSinceLastClear()
         configureUserOptions(ClearWhatOption.CLEAR_TABS_AND_DATA, ClearWhenOption.APP_EXIT_OR_5_MINS)

app/src/androidTest/java/com/duckduckgo/app/fire/DataClearerTimeKeeperTest.kt

@@ -88,4 +88,4 @@ class DataClearerTimeKeeperTest(private val testCase: TestCase) {
         val durationBackgrounded: Long,
         val timeNow: Long
     )
-}
+}

app/src/androidTest/java/com/duckduckgo/app/fire/GetCookieHostsToPreserveTest.kt

@@ -77,4 +77,4 @@ class GetCookieHostsToPreserveTest {
     private fun givenFireproofWebsitesStored(fireproofWebsiteEntity: FireproofWebsiteEntity) {
         fireproofWebsiteDao.insert(fireproofWebsiteEntity)
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/fire/RemoveCookiesTest.kt

@@ -54,4 +54,4 @@ class RemoveCookiesTest {
     private suspend fun CookieRemover.fails() {
         whenever(this.removeCookies()).thenReturn(false)
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/fire/SQLCookieRemoverTest.kt

@@ -141,4 +141,4 @@ class SQLCookieRemoverTest {
             dispatcherProvider
         )
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/fire/UnsentForgetAllPixelStoreSharedPreferencesTest.kt

@@ -76,4 +76,4 @@ class UnsentForgetAllPixelStoreSharedPreferencesTest {
         testee.resetCount()
         assertEquals(0, testee.pendingPixelCountClearData)
     }
-}
+}

app/src/androidTest/java/com/duckduckgo/app/fire/WebViewCookieManagerTest.kt

@@ -118,4 +118,4 @@ class WebViewCookieManagerTest {
     companion object {
         private const val DDG_HOST = "duckduckgo.com"
     }
-}
+}