Skip to content

Conversation

@marcosholgado
Copy link
Contributor

@marcosholgado marcosholgado commented May 21, 2020

Task/Issue URL: https://app.asana.com/0/488551667048375/1176838543253371
Tech Design URL:
CC:

Description:
There are two bugs related with the new privacy grade animation.

Grade does not show in SERP
In some cases we get notified twice about the progress reaching 100, when this happens the state of the privacy changes to be hidden.

  1. Go to cnn.com, animation happens as usual.
  2. Go to SERP, you can briefly see the grade and then it disappears.

Grade shows during the animation for a brief time
In some cases while navigating to a different page you can see the old grade showing up during the animation for a split second. This happens because the privacy state returns shouldAnimate as true and showEmptyGrade as false, showEmptyGrade takes precedence and hides the grade.

  1. Go to SERP.
  2. Go to cnn.com, you can briefly see the A grade during the animation.

Steps to test this PR:

  1. Go to cnn.com
  2. Go to SERP and notice how we show the A grade as usual.

Second scenario

  1. Go to SERP.
  2. Go to cnn.com, previous grade does not show during the animation.

Internal references:

Software Engineering Expectations
Technical Design Template

@subsymbolic subsymbolic self-assigned this May 21, 2020
@marcosholgado marcosholgado merged commit 24dd25b into develop May 21, 2020
@marcosholgado marcosholgado deleted the feature/marcos/fix_privacy_grade branch May 21, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants