Fix privacy grade bugs #836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1176838543253371
Tech Design URL:
CC:
Description:
There are two bugs related with the new privacy grade animation.
Grade does not show in SERP
In some cases we get notified twice about the progress reaching 100, when this happens the state of the privacy changes to be hidden.
Grade shows during the animation for a brief time
In some cases while navigating to a different page you can see the old grade showing up during the animation for a split second. This happens because the privacy state returns shouldAnimate as true and showEmptyGrade as false, showEmptyGrade takes precedence and hides the grade.
Steps to test this PR:
Second scenario
Internal references:
Software Engineering Expectations
Technical Design Template