Skip to content

Conversation

@CDRussell
Copy link
Member

Task/Issue URL: https://app.asana.com/0/414730916066338/1177254132666789
Tech Design URL:
CC:

Description:
Check for DownloadManager being disabled before downloading files to prevent a crash

Useful for testing: being able to go disable DownloadManager

    val intent = Intent(android.provider.Settings.ACTION_APPLICATION_DETAILS_SETTINGS)
    intent.data = Uri.parse("package:com.android.providers.downloads")
    startActivity(intent)

Steps to test this PR:

  1. Disable DownloadManager (see above)
  2. Attempt to download a file (e.g, http://www.granditaliaperth.co.uk/menus.html and find the download link)
  3. Verify the app doesn't crash, and that a snackbar is shown
  4. Click on ENABLE
  5. Verify download manager app settings screen is shown
  6. Enable DownloadManager
  7. Try download again

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will also approve it 👯‍♀️

@CDRussell CDRussell merged commit 047fe04 into develop May 28, 2020
@CDRussell CDRussell deleted the feature/craig/check_for_downloadmanager_before_downloading branch May 28, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants