Skip to content

Conversation

@subsymbolic
Copy link
Contributor

@subsymbolic subsymbolic commented Jun 1, 2020

Task/Issue URL: https://app.asana.com/0/361428290920652/1175573289211364/f

Description:
Update to latest embedded tracker data set and url/

Steps to test this PR:

Test the following on a high-end and low-end device

Test update url:

  1. Update tds.json to be empty {}
  2. Run a fresh version of the app and wait for download sync job to complete, you will see "Download task completed successfully" in the logs
  3. Visit a website e.g cnn.com and ensure that trackers are blocked

Test embedded when download fails:

  1. Revert previous changes
  2. Update the the tds.json link in TrackerListService to be giberish so the download will failr
  3. Install the app
  4. Visit a website e.g cnn.com and ensure that trackers are blocked

Internal references:

Software Engineering Expectations
Technical Design Template

@marcosholgado marcosholgado self-assigned this Jun 1, 2020
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@subsymbolic
Copy link
Contributor Author

Thanks for the review. And nice work adding the eTag test last time you were in this areas. It's an easy step to miss otherwise.

@subsymbolic subsymbolic merged commit e44c285 into develop Jun 1, 2020
@subsymbolic subsymbolic deleted the feature/mia/tds_update branch June 1, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants