Feature/craig/fix overflow menu state upon navigating back home #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that when you navigate forwards, the state is correctly identified as having changed from the previous state. Without this, the states are compared and we conclude the state is unchanged, and the `site` is never rebuilt so remains null.
malmstein
approved these changes
Jun 2, 2020
Contributor
malmstein
left a comment
malmstein
left a comment
There was a problem hiding this comment.
We went through the changes together and this PR solves what intends to. I've been playing around with API 21, API 26 and Android 10 and it works as expected.
Good job @CDRussell !
CDRussell
deleted the
feature/craig/fix_overflow_menu_state_upon_navigating_back_home
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Description:
Fixes the navigation state problems for the overflow and privacy grade.
Steps to test this PR:
Ago forwardInternal references:
Software Engineering Expectations
Technical Design Template