Login detection for fireproofing #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_js # Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt # app/src/main/java/com/duckduckgo/app/browser/WebViewClientListener.kt # app/src/main/java/com/duckduckgo/app/fire/fireproofwebsite/ui/FireproofWebsitesViewModel.kt # app/src/main/res/values/string-untranslated.xml
…n_fireproof # Conflicts: # app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
subsymbolic
reviewed
Jun 12, 2020
…ities. Differentiate between injected login detector and user navigation login detector
Contributor
Author
|
Hi @subsymbolic, I pushed some changes we agreed in https://app.asana.com/0/715106103902962/1180380358556618 PR description has been updated and also the description for the implementation task (https://app.asana.com/0/715106103902962/1179242968971107) This is now ready to be reviewed again. Thanks! |
subsymbolic
approved these changes
Jun 25, 2020
Contributor
|
Looks good! Feel free to merge once conflicts are fixed. |
…n_fireproof # Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
…n_fireproof # Conflicts: # app/src/main/res/values/styles.xml
malmstein
reviewed
Jun 29, 2020
Contributor
malmstein
left a comment
malmstein
left a comment
There was a problem hiding this comment.
Checked the new strings and it looks as expected. Good stuff @cmonfortep
cmonfortep
deleted the
feature/cristian/fireproof/login_detection_fireproof
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1149059203486286/1179242968971107/f
Tech Design URL: https://app.asana.com/0/1149059203486286/1176922255591995/f
CC: https://app.asana.com/0/1149059203486286/1176752473916553/f
Description:
Help users preserve logins to sites they frequent by adding the fireproofing prompt after login events on Android.
Includes:
Steps to test this PR:
#Test 1: No login detection
#Test 2: Login detection
#Test 3: Login detection
#Test 4: pixel enable/disable login detection
m_fw_d_e/ disable:m_fw_d_d)#Test 5: pixel on dialogs
m_fw_ld_sm_fw_l_dm_fw_l_a#Test 6: pixel on overflow mane
m_fw_am_fw_rInternal references:
Software Engineering Expectations
Technical Design Template