Add FireDialog theme in order to fix navigation buttons hiden on some devices

[ezanetta]

Resolves #754

Description:

• Added style to FireDialog, and override some properties in order to fix this issue :)

1. windowIsFloating as true
2. navigationBarColor as ?toolbarBgColor (light/dark theme)
3. statusBarColor as @android:color/transparent

Tested on:

• Pixel XL api 29 emulator
• Pixel 3XL api 29 emulator
• Pixel 3a XL api 29 device

Old	New

Live preview

---

Internal references:

Software Engineering Expectations
Technical Design Template

[cmonfortep]

Thanks, this looks great and it's simple to understand. I'm really looking forward for this fix!

I have only a comment related android:navigationBarColor, we should use it only for api > 27 to avoid some UI issues in low api devices.

Here a screenshot of how the bug looks like in api 21 (see that navigation buttons are also white and they are not visible):

Thanks!

[cmonfortep]

This produces a UI issue on low api devices. We had a similar issue in the past, where using white color makes all navigation buttons not visible. To avoid that bug I suggest you to create a new style for v27. I think we just need to keep this style here but without that attribute, and move this style to v27 style file.

Also, even if they are the same, I think is better to use colorPrimary instead.

[ezanetta]

Oh, I didn't realize about that issue, sure, sounds good to me, thanks!

[cmonfortep]

No problem at all, it also happened to us in the past. Happy you can work on this and make it happen 🚀

[ezanetta]

I removed android:navigationBarColor from the main style, and move it to v27 file and now it's working great. I tried on api 29 / 21 / 23. I tried with colorPrimary but the result was @color/almostBlackDark instead of the actual primary color, I found another style on v27 using <item name="android:navigationBarColor">?toolbarBgColor</item> so I think it's ok? Let me know if we can improve anything 🙌

[ezanetta]

Also I noticed we can avoid the property <item name="android:navigationBarColor">?toolbarBgColor</item> and the navigationBar works fine, the nav buttons are visible, but the nav background is always black (I think it takes the navBar system default color)

[cmonfortep]

About using ?toolbarBgColor, if we are already using that color is ok 👍

And about about low api devices always being black is also ok, it's our expected behavior to avoid problems the problems I described with navigation buttons.

[cmonfortep]

Thanks, code wise looks great. I'm going to approve it. I will merge it as soon as I do some final checks. I will let you know 👍

[cmonfortep]

Thanks for the fix @ezanetta. This is now merged.

[ezanetta]

Thanks for the fix @ezanetta. This is now merged.

Thanks Cristian, I'm glad I can help 😄