Skip to content

Deactivate experiment: Android: Test notification drip campaign with inactive users #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Deactivate experiment: Android: Test notification drip campaign with inactive users #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ class VariantManagerTest {
// Notification Drip Experiment

@Test
fun notificationDripTestControlGroupVariantActive() {
fun notificationDripTestControlGroupVariantIsNotActive() {
val variant = variants.firstOrNull { it.key == "za" }
assertEqualsDouble(1.0, variant!!.weight)
assertEqualsDouble(0.0, variant!!.weight)
}

@Test
Expand All @@ -61,9 +61,9 @@ class VariantManagerTest {
}

@Test
fun notificationDripTestNullVariantActive() {
fun notificationDripTestNullVariantIsNotActive() {
val variant = variants.firstOrNull { it.key == "zb" }
assertEqualsDouble(1.0, variant!!.weight)
assertEqualsDouble(0.0, variant!!.weight)
}

@Test
Expand All @@ -74,9 +74,9 @@ class VariantManagerTest {
}

@Test
fun notificationDripA1TestVariantActive() {
fun notificationDripA1TestVariantIsNotActive() {
val variant = variants.firstOrNull { it.key == "zc" }
assertEqualsDouble(1.0, variant!!.weight)
assertEqualsDouble(0.0, variant!!.weight)
}

@Test
Expand All @@ -89,9 +89,9 @@ class VariantManagerTest {
}

@Test
fun notificationDripA2TestVariantActive() {
fun notificationDripA2TestVariantIsNotActive() {
val variant = variants.firstOrNull { it.key == "zd" }
assertEqualsDouble(1.0, variant!!.weight)
assertEqualsDouble(0.0, variant!!.weight)
}

@Test
Expand All @@ -104,9 +104,9 @@ class VariantManagerTest {
}

@Test
fun notificationDripB1TestVariantActive() {
fun notificationDripB1TestVariantIsNotActive() {
val variant = variants.firstOrNull { it.key == "ze" }
assertEqualsDouble(1.0, variant!!.weight)
assertEqualsDouble(0.0, variant!!.weight)
}

@Test
Expand All @@ -119,9 +119,9 @@ class VariantManagerTest {
}

@Test
fun notificationDripB2TestVariantActive() {
fun notificationDripB2TestVariantIsNotActive() {
val variant = variants.firstOrNull { it.key == "zf" }
assertEqualsDouble(1.0, variant!!.weight)
assertEqualsDouble(0.0, variant!!.weight)
}

@Test
Expand Down
12 changes: 6 additions & 6 deletions app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,32 +55,32 @@ interface VariantManager {
// Notification Drip Experiment
Variant(
key = "za",
weight = 1.0,
weight = 0.0,
features = listOf(VariantFeature.DripNotification, VariantFeature.Day1PrivacyNotification, VariantFeature.Day3ClearDataNotification),
filterBy = { isEnglishLocale() }),
Variant(
key = "zb",
weight = 1.0,
weight = 0.0,
features = listOf(VariantFeature.DripNotification),
filterBy = { isEnglishLocale() }),
Variant(
key = "zc",
weight = 1.0,
weight = 0.0,
features = listOf(VariantFeature.DripNotification, VariantFeature.Day1DripA1Notification, VariantFeature.Day3ClearDataNotification),
filterBy = { isEnglishLocale() }),
Variant(
key = "zd",
weight = 1.0,
weight = 0.0,
features = listOf(VariantFeature.DripNotification, VariantFeature.Day1DripA2Notification, VariantFeature.Day3ClearDataNotification),
filterBy = { isEnglishLocale() }),
Variant(
key = "ze",
weight = 1.0,
weight = 0.0,
features = listOf(VariantFeature.DripNotification, VariantFeature.Day1DripB1Notification, VariantFeature.Day3ClearDataNotification),
filterBy = { isEnglishLocale() }),
Variant(
key = "zf",
weight = 1.0,
weight = 0.0,
features = listOf(VariantFeature.DripNotification, VariantFeature.Day1DripB2Notification, VariantFeature.Day3ClearDataNotification),
filterBy = { isEnglishLocale() }),

Expand Down