-
Notifications
You must be signed in to change notification settings - Fork 1.1k
In app usage flows now only applies to new users under a new variant. #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ation so they don't get trapped in that stage.
app/src/main/java/com/duckduckgo/app/notification/AndroidNotificationScheduler.kt
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/tabs/model/TabDataRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/shortcut/ShortcutReceiver.kt
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/shortcut/ShortcutReceiver.kt
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/shortcut/ShortcutBuilder.kt
Show resolved
Hide resolved
cmonfortep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, none of them critical. I will test this tomorrow. Everything looks great!
app/src/main/java/com/duckduckgo/app/tabs/model/TabDataRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/notification/AndroidNotificationScheduler.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/duckduckgo/app/notification/model/UseOurAppNotificationTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/global/DuckDuckGoApplication.kt
Outdated
Show resolved
Hide resolved
cmonfortep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just heads-up, code looks great! I will continue with testing.
cmonfortep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested and everything works as described. Good work, Thanks.
Task/Issue URL: https://app.asana.com/0/1125189844152671/1186436893520548
Tech Design URL:
CC:
Description:
This PR prepares the in app usage flow for the second experiment, includes:
Before testing
In
DuckDuckGoApplicationlines 221 and 222 change the code to:You will be now moved out of the onboarding stage after 30 seconds from install whenever you resume the app.
In
AndroidNotificationSchedulerlines 58 and 59 change the code to be40andTimeUnit.SECONDS. Also change the line 75 to be:The notifications will be now triggered after 40 seconds.
Steps to test this PR:
Updating from previous version when in use our app notification stage
userStagetable in the database inspector to beUSE_OUR_APP_NOTIFICATIONin the appStage column.appStagein the database should now beESTABLISHEDVariant zl - In App usage flow
Hardcode the variant to use
zlClicking the notification moves you out of the onboarding
instagram.com.After X time you are moved out of the onboarding
Hiding tips does not show the notification
Variant zk - Removes onboarding and day1/3 notifications
Hardcode the variant to use
zkAfter X time you are moved out of the onboarding and no notifications are scheduled
Pixels and tabs
m_uoa_vshould be sent.m_uoa_s_ashould be sentm_sho_uoa_oandm_uoa_vshould be sent.Variant zj - Control
Hardcode the variant to use
zkNotification and onboarding
Pixels and tabs
m_uoa_vshould be sent.m_uoa_s_ashould be sentm_sho_uoa_oandm_uoa_vshould be sent.Internal references:
Software Engineering Expectations
Technical Design Template