Fix crash that could happen when trying to download a large data URI image #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also tidies up some of the code around the DownloadConfirmationFragment, which had a leak and was doing a fair bit; moving some of the logic out of here to keep this dialog focussed on obtaining the user choice makes things simpler.
cmonfortep
reviewed
Aug 7, 2020
|
|
||
| override fun handleLongPress(longPressTargetType: Int, longPressTargetUrl: String?, menu: ContextMenu) { | ||
| menu.setHeaderTitle(longPressTargetUrl ?: context.getString(R.string.options)) | ||
| menu.setHeaderTitle(longPressTargetUrl?.take(MAX_TITLE_LENGTH) ?: context.getString(R.string.options)) |
cmonfortep
approved these changes
Aug 7, 2020
Contributor
cmonfortep
left a comment
cmonfortep
left a comment
There was a problem hiding this comment.
LGTM All works as described. Good work fixing this issue, thanks!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1187803392412385/f
Tech Design URL:
CC:
Description:
We saw crash instances when a user attempts to save a data URI. This PR fixes that, and has a few related improvements to that area
Simplifies the
DownloadConfirmationFragmentLimits the title length for the long press menu. An exceedingly long data URI could trigger an ANR as we were trying to populate a
TextViewwith potentially megabytes of data (and the UI already capped what it could output)Steps to reproduce crash
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template