Update tooling to targetSdkVersion 29 and compileSdkVersion 29 #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed nullability issue with StringHtmlExtension.kt extension function - Fixed nullability issue with NavigationAwareLoginDetector.kt - Fixed nullability issue with BrowserTabFragment.kt's interaction with ClipboardManager - Fixed nullability issue with NotificationHandlerService.kt's intent parsing
CDRussell
commented
Aug 7, 2020
app/src/main/java/com/duckduckgo/app/browser/logindetection/NavigationAwareLoginDetector.kt
Outdated
Show resolved
Hide resolved
Member
Author
|
@cmonfortep, thanks for your changes; they're good with me. I'll throw the whole PR back at you for a final review if you don't mind. |
cmonfortep
approved these changes
Aug 10, 2020
Contributor
cmonfortep
left a comment
cmonfortep
left a comment
There was a problem hiding this comment.
LGTM, Thanks @CDRussell, finished reviewing the rest of the files in this PR. 👍
Contributor
|
@CDRussell this can be merged and I'll add it to the next release unless something else is stopping it? |
Member
Author
|
I had originally planned to put this out in its own release but then quite a few releases started happening; i'm happy to include it with other PRs though. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1187618988784913/f
Tech Design URL:
CC:
Description:
Bumping the target and compile SDK versions resulted in some compilation errors, mostly around stricter nullability checks.
Steps to test this PR:
There is the possibility of a subtle problem being introduced anywhere though, so need to verify the whole app is still working as expected.
Internal references:
Software Engineering Expectations
Technical Design Template