Skip to content

Conversation

@marcosholgado
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1125189844152671/1184979058928819
Tech Design URL: https://app.asana.com/0/1125189844152671/1185601980752281
CC:

Description:
This PR stops loading a website if we detect a possible DoS attack via the location.reload() method and shows an error to the user.

Steps to test this PR:
Test on low (<24) and high APIs (>24)

DoS website stops loading and returns error

  1. Navigate to http://ddgdos.000webhostapp.com/dos.html
  2. The website should stop loading within a few seconds and show a Snackbar error.
  3. Click on reload.
  4. The Snackbar should disappear and the website should try to reload.
  5. The website should stop loading within a few seconds and show a Snackbar error again.
  6. Do a search or navigate to a different URL.
  7. The new website should load as expected and the Snackbar should disappear.

Website with internal reloads works as expected

  1. Navigate to facebook.com and log in.
  2. Search the logout option and logout
  3. Website should load correctly.

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@subsymbolic subsymbolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@marcosholgado marcosholgado self-assigned this Aug 11, 2020
Copy link
Contributor Author

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes to the dos detector 👍

@marcosholgado marcosholgado merged commit b973426 into develop Aug 11, 2020
@marcosholgado marcosholgado deleted the feature/shared/dos branch August 11, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants