-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Feature/shared/dos #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/shared/dos #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uckgo/Android into feature/shared/dos
subsymbolic
reviewed
Aug 11, 2020
subsymbolic
approved these changes
Aug 11, 2020
Contributor
subsymbolic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
marcosholgado
commented
Aug 11, 2020
Contributor
Author
marcosholgado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes to the dos detector 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1125189844152671/1184979058928819
Tech Design URL: https://app.asana.com/0/1125189844152671/1185601980752281
CC:
Description:
This PR stops loading a website if we detect a possible DoS attack via the
location.reload()method and shows an error to the user.Steps to test this PR:
Test on low (<24) and high APIs (>24)
DoS website stops loading and returns error
http://ddgdos.000webhostapp.com/dos.htmlWebsite with internal reloads works as expected
Internal references:
Software Engineering Expectations
Technical Design Template