Skip to content

Conversation

@marcosholgado
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1125189844152671/1187357199382446
Tech Design URL:
CC:

Description:
This PR updates the English copy for the network Dax dialog. The translations are delayed and in the meantime we prefer to do this only in English. Because the copy is different from the previous one we have to check in the CTA if the locale is English to apply the correct substitutions.

New copy
_Heads up! Since Facebook owns instagram.com, I can't stop them from seeing your activity here.

But browse with me, and I can reduce what Facebook knows about you overall by blocking their trackers on lots of other sites._

Steps to test this PR:

  1. Launch the app in English.
  2. Go to instagram.com
  3. New copy should be shown

Non-English:

  1. Re-install and launch the app in Spanish or any other language.
  2. Go to instagram.com
  3. Old copy should be shown (it has an emoji and contains a %).

Internal references:

Software Engineering Expectations
Technical Design Template

@cmonfortep cmonfortep self-assigned this Aug 12, 2020
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@marcosholgado marcosholgado merged commit 247ebba into develop Aug 13, 2020
@marcosholgado marcosholgado deleted the feature/marcos/dax_copy branch August 13, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants