Replaced dialog box with snackbar in Bookmarks+fireproof websites

[anoopaneesh]

Addressing issue: #945

I have a added a snackbar when user deletes a bookmark or fireproof website.The snackbar contains a undo option which can be used to cancel the deletion.I have used string resources instead of hardcoded string .

[cmonfortep]

@anoopaneesh Thanks for the contribution!

This is failing because our ktlint detected some codestyle issues:

/bitrise/src/app/src/main/java/com/duckduckgo/app/bookmarks/ui/BookmarksActivity.kt:143:61: Missing spacing before "{"
/bitrise/src/app/src/main/java/com/duckduckgo/app/bookmarks/ui/BookmarksViewModel.kt:34:1: Unused import
/bitrise/src/app/src/main/java/com/duckduckgo/app/bookmarks/ui/BookmarksViewModel.kt:108:41: Missing spacing before "{"
/bitrise/src/app/src/main/java/com/duckduckgo/app/fire/fireproofwebsite/ui/FireproofWebsitesActivity.kt:30:1: Unused import
/bitrise/src/app/src/main/java/com/duckduckgo/app/fire/fireproofwebsite/ui/FireproofWebsitesActivity.kt:83:61: Missing spacing before "{"
/bitrise/src/app/src/main/java/com/duckduckgo/app/fire/fireproofwebsite/ui/FireproofWebsitesViewModel.kt:75:64: Missing spacing before "{"
/bitrise/src/app/src/main/java/com/duckduckgo/app/fire/fireproofwebsite/ui/FireproofWebsitesViewModel.kt:77:55: Missing spacing before "{"

You can fix them manually, or configure your Android studio with our setup.

[malmstein]

Thanks for the contribution @anoopaneesh! I'll take a look at the implementation during this week.

[malmstein]

Thanks for the contribution @anoopaneesh, a few comments before I do some manual testing:

• Can you add tests for the new methods added to the ViewModel?
• This project is translated to several languages, but you have only changed the text for English. Can you add two new entries to strings-untranslated with the new snackbars messages? Also remove the old bookmarkDeleteConfirmMessage and fireproofWebsiteDeleteConfirmMessage from all the other string files.

[anoopaneesh]

added two new entries to strings-untranslated with the new snackbars messages. Also removed the old bookmarkDeleteConfirmMessage and fireproofWebsiteDeleteConfirmMessage from all the other string files.

[malmstein]

Thanks for updating the strings @anoopaneesh, once the tests are added to the ViewModel we can close this one.

[cmonfortep]

@anoopaneesh Do you have plans to address the comments in this PR? Thanks.

[anoopaneesh]

I am really sorry that i couldnt work on these. I am not good at testing

…

On Thu, Jan 7, 2021, 10:01 PM Cristian Monforte ***@***.***> wrote: @anoopaneesh <https://github.com/anoopaneesh> Do you have plans to address the comments in this PR? Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#951 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANVE75QHMT6RXSMRMOFUXC3SYXOWXANCNFSM4SAK4AQQ> .

[malmstein]

I've created #1056 to add the missing tests and fix the conflicts shown here