Skip to content

Conversation

@moon0326
Copy link
Contributor

@moon0326 moon0326 commented Oct 22, 2025

Asana Task/Github Issue:
https://app.asana.com/1/137249556945/project/1211592734365220/task/1211616566794262

Description

  • Fix text cut-off issue on Windows

Before: Notice that g and j are cut off

Screenshot 2025-10-22 at 1 10 42 PM

After:

Screenshot 2025-10-22 at 1 12 25 PM

Testing Steps

For testing this change, you would need to use Windows.

  1. Clone this branch.
  2. Run npm run watch -- --page new-tab
  3. Copy the URL and open it on Windows, adding ?platform=windows&omnibar query string.
  4. Type g and j
  5. Verify that both letters render correctly without being cut off. Try other letters as well.

If you have windows-browser dev environment,

  1. Run npm run build command (in this repo).
  2. Copy build/windows (this repo) directory to submodules/content-scope-scripts/build/windows (window-browser repo)
  3. Build window-browser and test the input again.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Set a Windows-specific line-height on the omnibar input to prevent text from being cut off, with minor selector quote normalization.

  • NTP Omnibar CSS (special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css):
    • Add Windows-specific rule setting .input { line-height: normal; } to prevent glyph clipping.
    • Normalize attribute selector quoting for Windows and omnibar listbox visibility selectors.

Written by Cursor Bugbot for commit 3e0a1f8. This will update automatically on new commits. Configure here.

@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 3e0a1f8
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68f93d1f389ee70008c16398
😎 Deploy Preview https://deploy-preview-2029--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

[Beta] Generated file diff

Time updated: Wed, 22 Oct 2025 20:24:05 GMT

Apple
    - apple/pages/new-tab/dist/index.css

File has changed

Integration
    - integration/pages/new-tab/dist/index.css

File has changed

Windows
    - windows/pages/new-tab/dist/index.css

File has changed

@moon0326 moon0326 marked this pull request as ready for review October 22, 2025 20:18
@moon0326 moon0326 requested review from a team, mgurgel and shakyShane as code owners October 22, 2025 20:18
cursor[bot]

This comment was marked as outdated.

@moon0326 moon0326 enabled auto-merge October 22, 2025 22:52
@moon0326 moon0326 added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit 6d035c7 Oct 22, 2025
20 checks passed
@moon0326 moon0326 deleted the moon0326/fix/windows-omnibar-input-cutoff branch October 22, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants