NTP - Fix text cut-off on windows #2029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue:
https://app.asana.com/1/137249556945/project/1211592734365220/task/1211616566794262
Description
Before: Notice that g and j are cut off
After:
Testing Steps
For testing this change, you would need to use Windows.
npm run watch -- --page new-tab?platform=windows&omnibarquery string.gandjIf you have windows-browser dev environment,
npm run buildcommand (in this repo).build/windows(this repo) directory tosubmodules/content-scope-scripts/build/windows(window-browser repo)Checklist
Please tick all that apply:
Note
Set a Windows-specific line-height on the omnibar input to prevent text from being cut off, with minor selector quote normalization.
special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css):.input { line-height: normal; }to prevent glyph clipping.Written by Cursor Bugbot for commit 3e0a1f8. This will update automatically on new commits. Configure here.