-
Notifications
You must be signed in to change notification settings - Fork 31
detector service for breakage reporting #2052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Fri, 21 Nov 2025 15:23:31 GMT Android
File has changed Apple
File has changed Chrome-mv3File has changed FirefoxFile has changed IntegrationFile has changed WindowsFile has changed |
madblex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I added some comments and a couple more here:
- I'd like to see how this integrates with content features, especially broker protection, i.e. the equivalent of this
- I see we removed
WebInterferenceDetectioncontent feature. Is it because you don't think we'll need a standalone feature for this? i.e. the detectors will only be called from other features. - I see we're going the functional route (from classes). Not feeling strongly (I prefer functional most of the time), I just believe the trade-off is that interfaces will be more difficult to enforce. I think classes provide a bit of a better structure, but this is opinionated.
|
|
|
@jonathanKingston Thanks for the review. I refactored this into a WebInterferenceDetection ContentFeature, got rid of the standalone service/init, and switched to using getFeatureSetting() conditionalChanges for config. Let me know what you think. |
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1211666118504301?focus=true
Description
Building on #2048 with a more generalize framework for breakage reports.
New detector service:
shouldRun()checks (only during auto-run)Changed:
See the injected/src/detectors/README.md for more details
Testing Steps
Checklist
Please tick all that apply:
Note
Introduce on-demand bot/fraud detectors and wire them into breakage reporting, enable new feature across platforms, and add integration tests with mock pages.
runBotDetectionandrunFraudDetectionwith shared helpers ininjected/src/detectors/**and fallbackdefault-config.injected/src/features/web-interference-detection.jsexposingdetectInterferencevia messaging.injected/src/features/breakage-reporting.jsto optionally includedetectorDatausingwebInterferenceDetectionsettings.webInterferenceDetectionininjected/src/features.jsand enable onapple,android,windows,chrome, andchrome-mv3.injected/integration-test/breakage-reporting.spec.jswith cases for clean page, Cloudflare, reCAPTCHA, and PerimeterX.injected/integration-test/test-pages/breakage-reporting/**.Written by Cursor Bugbot for commit 7d8619c. This will update automatically on new commits. Configure here.