-
Notifications
You must be signed in to change notification settings - Fork 31
Add configurable timeout for perf metrics #2057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added timeout parameter to getExpandedPerformanceMetrics function to control waiting time for largest contentful paint.
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Tue, 02 Dec 2025 12:00:06 GMT Android
File has changed AppleFile has changed Chrome-mv3File has changed IntegrationFile has changed WindowsFile has changed |
shakyShane
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue:
Description
Allow for remote config for the timing data for LCP.
Testing Steps
Checklist
Please tick all that apply:
Note
Use a configurable timeout (feature setting
expandedTimeoutMs, default 5s) for LCP when collecting expanded performance metrics.getExpandedPerformanceMetrics(timeoutMs = 500)to accept a timeout and pass it towaitForLCP.PerformanceMetrics.triggerExpandedPerformanceMetrics, readexpandedTimeoutMs(default5000) from feature settings and pass it togetExpandedPerformanceMetrics.Written by Cursor Bugbot for commit 7f99878. This will update automatically on new commits. Configure here.