Skip to content

Conversation

@jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Nov 21, 2025

Asana Task/Github Issue:

Description

Allow for remote config for the timing data for LCP.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Use a configurable timeout (feature setting expandedTimeoutMs, default 5s) for LCP when collecting expanded performance metrics.

  • Expanded performance metrics:
    • Update getExpandedPerformanceMetrics(timeoutMs = 500) to accept a timeout and pass it to waitForLCP.
    • In PerformanceMetrics.triggerExpandedPerformanceMetrics, read expandedTimeoutMs (default 5000) from feature settings and pass it to getExpandedPerformanceMetrics.

Written by Cursor Bugbot for commit 7f99878. This will update automatically on new commits. Configure here.

Added timeout parameter to getExpandedPerformanceMetrics function to control waiting time for largest contentful paint.
@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 7f99878
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/692ed4840e49370008be35fb
😎 Deploy Preview https://deploy-preview-2057--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

[Beta] Generated file diff

Time updated: Tue, 02 Dec 2025 12:00:06 GMT

Android
    - android/adsjsContentScope.js
  • android/contentScope.js

File has changed

Apple
    - apple/contentScopeIsolated.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

@jonathanKingston jonathanKingston marked this pull request as ready for review November 22, 2025 15:21
@jonathanKingston jonathanKingston requested a review from a team as a code owner November 22, 2025 15:21
@jonathanKingston jonathanKingston added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit 6f675d9 Dec 2, 2025
18 checks passed
@jonathanKingston jonathanKingston deleted the jkt/timeoutPerfMetrics branch December 2, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants