Skip to content

Commit 096fabb

Browse files
committed
feat: ignore falsy values in prepends/appends/deps, so it is easier for user to do conditional config
1 parent ae72929 commit 096fabb

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

spec/bundler.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ test('Bundler traces files', t => {
7777
'node_modules/loo/loo.js': '',
7878
};
7979
const bundler = createBundler(fakeFs, {
80-
prepends: ['var pre = 1;', 'local/setup.js'],
80+
prepends: ['var pre = 1;', '', undefined, false, 'local/setup.js', null],
8181
appends: ['local/after.js', 'var ape = 1;']
8282
});
8383

src/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,14 @@ export default class Bundler {
5050
this._depsFinder = opts.depsFinder;
5151
this._onRequire = opts.onRequire || opts.onrequire || opts.onRequiringModule;
5252

53-
this._prepends = opts.prepends || opts.prepend || [];
53+
this._prepends = (opts.prepends || opts.prepend || []).filter(t => t);
5454
this._prepends.push(
5555
// load dumber-module-loader after prepends
5656
path.join(_resolve('dumber-module-loader'), 'dist/index.js')
5757
);
58-
this._appends = opts.appends || opts.append || [];
58+
this._appends = (opts.appends || opts.append || []).filter(t => t);
5959

60-
this._dependencies = (opts.dependencies || opts.deps || []).map(d => new Package(d));
60+
this._dependencies = (opts.dependencies || opts.deps || []).filter(t => t).map(d => new Package(d));
6161
this._entryBundle = stripJsExtension(opts.entryBundle) || 'entry-bundle';
6262
this._codeSplit = opts.codeSplit || function(){};
6363
// mark dirtiness of bundles

0 commit comments

Comments
 (0)