Skip to content

Commit 5a07d94

Browse files
committed
fix: fix missing dep on base64-arraybuffer
1 parent 153d7b3 commit 5a07d94

4 files changed

Lines changed: 11 additions & 3 deletions

File tree

spec/trace.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ test('trace transforms wasm file', t => {
202202
sourceMap: undefined,
203203
moduleId: 'foo/bar.wasm',
204204
defined: 'raw!foo/bar.wasm',
205-
deps: [],
205+
deps: ['base64-arraybuffer'],
206206
packageName: undefined,
207207
shimed: undefined
208208
})

spec/transformers/wasm.spec.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ test('wasm wraps wasm into amd module', t => {
77

88
t.deepEqual(wasm('a.wasm', source), {
99
defined: 'raw!a.wasm',
10-
contents: target
10+
contents: target,
11+
deps: ['base64-arraybuffer']
1112
});
1213
t.end();
1314
});

src/trace.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,18 @@ export default function (unit, opts = {}) {
8181
let wasmResult = wasm(moduleId, contents);
8282
contents = wasmResult.contents;
8383
defined = wasmResult.defined;
84+
if (wasmResult.deps) {
85+
wasmResult.deps.forEach(d => deps.add(resolveModuleId(moduleId, d)));
86+
}
8487
} else {
8588
// use text! for everything else including unknown extname
8689
sourceMap = undefined;
8790
let textResult = text(moduleId, contents);
8891
contents = textResult.contents;
8992
defined = textResult.defined;
93+
if (textResult.deps) {
94+
textResult.deps.forEach(d => deps.add(resolveModuleId(moduleId, d)));
95+
}
9096
}
9197

9298
let p = Promise.resolve();

src/transformers/wasm.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
export default function (moduleId, base64) {
33
return {
44
defined: `raw!${moduleId}`,
5-
contents:`define('raw!${moduleId}',['base64-arraybuffer'],function(a){return {arrayBuffer: function() {return a.decode(${JSON.stringify(base64)});}}});\n`
5+
contents:`define('raw!${moduleId}',['base64-arraybuffer'],function(a){return {arrayBuffer: function() {return a.decode(${JSON.stringify(base64)});}}});\n`,
6+
deps: ['base64-arraybuffer']
67
};
78
}

0 commit comments

Comments
 (0)