feat: support nodejs globals: global, process, Buffer

Author: 3cp

spec/parser.uses-common-js.spec.js

@@ -110,3 +110,8 @@ module.exports = require('./_library') || !require('./_fails')(function () {
   t.deepEqual(usesCommonJs(code), {require: true, moduleExports: true});
   t.end();
 });
+
+test('usesCommonJs picks nodejs global, process, and Buffer', t => {
+  t.deepEqual(usesCommonJs("if (global) { Buffer.from(process.cwd()); }"), {'global': true, 'Buffer': true, 'process': true});
+  t.end();
+});

spec/transformers/cjs-es.spec.js

@@ -74,3 +74,13 @@ test('cjsEs transform wraps ES module', t => {
   t.ok(result.contents.startsWith('define(["exports"'));
   t.end();
 });
+
+test('cjsEs transform wraps cjs code with global, process, and Buffer', t => {
+  const source = 'exports.name = global.bar;exports.loo = new Buffer(process.cwd());';
+  const expected = 'define(function (require, exports, module) {' +
+                   'var global = window;var process = require(\'process\');var Buffer = require(\'buffer\').Buffer;\n' +
+                   'exports.name = global.bar;exports.loo = new Buffer(process.cwd());\n});\n';
+
+  t.deepEqual(cjsEs(source), {headLines: 1, contents: expected});
+  t.end();
+});

src/parser.js

@@ -75,10 +75,14 @@ export function usesCommonJs (code, globals) {
     usage.require = true;
   }
 
-  if (globals['exports']) usage.exports = true;
-  if (globals['module']) usage.moduleExports = true;
-  if (globals['__dirname']) usage.dirname = true;
-  if (globals['__filename']) usage.filename = true;
+  if (globals['exports']) usage['exports'] = true;
+  if (globals['module']) usage['moduleExports'] = true;
+  if (globals['__dirname']) usage['dirname'] = true;
+  if (globals['__filename']) usage['filename'] = true;
+  // special nodejs globals
+  if (globals['global']) usage['global'] = true;
+  if (globals['process']) usage['process'] = true;
+  if (globals['Buffer']) usage['Buffer'] = true;
 
   if (Object.keys(usage).length) {
     return usage;
@@ -129,21 +133,21 @@ export function usesAmdOrRequireJs (code, globals) {
   }
   let usage = {};
 
-  if (globals['requirejs']) usage.requirejs = true;
+  if (globals['requirejs']) usage['requirejs'] = true;
 
   if (globals['require']) {
     let list = globals['require'];
     if (some(list, findAmdRequireIdentifiers(ast))) {
-      usage.require = true;
+      usage['require'] = true;
     }
 
     if (some(list, findAmdRequireConfigIdentifiers(ast))) {
-      usage.requireConfig = true;
+      usage['requireConfig'] = true;
     }
   }
 
   if (globals['define']) {
-    usage.define = true;
+    usage['define'] = true;
     // We didn't implement declaresDefine and defineAmd here.
     // If we want, use eslint-scope getDeclaredVariables(node) api to get function definition in inner scope.
   }

src/transformers/cjs-es.js

@@ -33,11 +33,23 @@ export default function(contents, forceWrap) {
 
   let pre = '';
   if (cjsUsage && (cjsUsage.dirname || cjsUsage.filename)) {
-    pre = 'var __filename = module.filename || \'\', ' +
+    pre += 'var __filename = module.filename || \'\', ' +
           '__dirname = ' +
           '__filename.slice(0, __filename.lastIndexOf(\'/\') + 1);';
   }
 
+  if (cjsUsage && cjsUsage['global']) {
+    pre += 'var global = window;';
+  }
+
+  if (cjsUsage && cjsUsage['process']) {
+    pre += "var process = require('process');";
+  }
+
+  if (cjsUsage && cjsUsage['Buffer']) {
+    pre += "var Buffer = require('buffer').Buffer;";
+  }
+
   return {
     headLines: 1,
     contents: 'define(function (require, exports, module) {' + pre + '\n' +