fix: remove inner defined modules from deps

Author: 3cp

spec/transformers/defines.spec.js

@@ -137,6 +137,17 @@ test('defines ignores multiple defines case 3', t => {
   t.end();
 });
 
+test('defines ignores inner deps', t => {
+  const multi = 'define("foo", function() {});\n' +
+                'define("bar", ["foo", "loo"], function (require) { var foo = require("foo"); });\n';
+  const r = defines('bar', multi);
+  t.deepEqual(r.defined, ['foo', 'bar']);
+  t.notOk(r.shimed);
+  t.deepEqual(r.deps, ["loo"]);
+  t.equal(r.contents, multi);
+  t.end();
+});
+
 test('defines ignores empty define call', t => {
   const empty = 'define();\n';
   const r = defines('empty', empty);

src/transformers/defines.js

@@ -25,9 +25,12 @@ export default function(moduleId, amdContents, shim) {
   }
 
   // remove cjs constants
-  result.deps = result.deps.filter(d =>
-    !(d === 'require' || d === 'exports' || d === 'module')
-  );
+  result.deps = result.deps.filter(d => {
+    if (d === 'require' || d === 'exports' || d === 'module') return false;
+    if (typeof result.defined === 'string' && d === result.defined) return false;
+    if (Array.isArray(result.defined) && result.defined.indexOf(d) !== -1) return false;
+    return true;
+  });
 
   if (!shim) return result;
   // bypass shim settings as package already defined amd module