fix: hopefully fixed stream stub

Author: 3cp

package.json

@@ -44,12 +44,12 @@
     "ast-matcher": "^1.0.1",
     "cherow": "^1.6.8",
     "del": "^3.0.0",
-    "dumber-module-loader": "^0.15.0",
+    "dumber-module-loader": "^0.15.2",
     "escope": "^3.6.0",
     "mkdirp": "^0.5.1",
     "node-fetch": "^2.3.0",
     "node-libs-browser": "^2.1.0",
-    "readable-stream": "^3.0.6"
+    "readable-stream": "^2.3.6"
   },
   "devDependencies": {
     "@babel/cli": "^7.2.0",

spec/stub-module.spec.js

@@ -27,9 +27,9 @@ test('stubModule stubs domain', t => {
   t.end();
 });
 
-test('stubModule stubs stream', t => {
-  t.deepEqual(stubModule('stream'),{
-    name: 'stream',
+test('stubModule stubs local readable-stream', t => {
+  t.deepEqual(stubModule('readable-stream'),{
+    name: 'readable-stream',
     location: resolve('readable-stream')
   });
   t.end();

src/stub-module.js

@@ -38,7 +38,7 @@ function resolve(packageName) {
 // note all paths here assumes local node_modules folder
 export default function(moduleId) {
   // with subfix -browserify
-  if (['crypto', 'https', 'os', 'path', 'timers', 'tty', 'vm'].indexOf(moduleId) !== -1) {
+  if (['crypto', 'https', 'os', 'path', 'stream', 'timers', 'tty', 'vm'].indexOf(moduleId) !== -1) {
     return {name: moduleId, location: resolve(`${moduleId}-browserify`)};
   }
 
@@ -47,9 +47,10 @@ export default function(moduleId) {
     return {name: 'domain', location: resolve('domain-browser')};
   }
 
-  if (moduleId === 'stream') {
-    // use new readable-stream instead of old stream-browserify
-    return {name: 'stream', location: resolve('readable-stream')};
+  if (moduleId === 'readable-stream') {
+    // forcing the local old readable-stream v2
+    // this is required by stream-browserify stub
+    return {name: 'readable-stream', location: resolve('readable-stream')};
   }
 
   if (moduleId === 'http') {