fix: use new readable-stream instead of old stream-browserify to stub nodejs core module stream

Author: 3cp

package.json

@@ -48,7 +48,8 @@
     "escope": "^3.6.0",
     "mkdirp": "^0.5.1",
     "node-fetch": "^2.3.0",
-    "node-libs-browser": "^2.1.0"
+    "node-libs-browser": "^2.1.0",
+    "readable-stream": "^3.0.6"
   },
   "devDependencies": {
     "@babel/cli": "^7.2.0",

spec/stub-module.spec.js

@@ -27,6 +27,14 @@ test('stubModule stubs domain', t => {
   t.end();
 });
 
+test('stubModule stubs stream', t => {
+  t.deepEqual(stubModule('stream'),{
+    name: 'stream',
+    location: resolve('readable-stream')
+  });
+  t.end();
+});
+
 test('stubModule stubs http', t => {
   t.deepEqual(stubModule('http'),{
     name: 'http',

src/stub-module.js

@@ -38,7 +38,7 @@ function resolve(packageName) {
 // note all paths here assumes local node_modules folder
 export default function(moduleId) {
   // with subfix -browserify
-  if (['crypto', 'https', 'os', 'path', 'stream', 'timers', 'tty', 'vm'].indexOf(moduleId) !== -1) {
+  if (['crypto', 'https', 'os', 'path', 'timers', 'tty', 'vm'].indexOf(moduleId) !== -1) {
     return {name: moduleId, location: resolve(`${moduleId}-browserify`)};
   }
 
@@ -47,6 +47,11 @@ export default function(moduleId) {
     return {name: 'domain', location: resolve('domain-browser')};
   }
 
+  if (moduleId === 'stream') {
+    // use new readable-stream instead of old stream-browserify
+    return {name: 'stream', location: resolve('readable-stream')};
+  }
+
   if (moduleId === 'http') {
     return {name: 'http', location: resolve('stream-http')};
   }