Skip to content

Commit bbbed7b

Browse files
committed
fix: fix mocha tests, remove tap-dot
1 parent d28bc97 commit bbbed7b

8 files changed

Lines changed: 8 additions & 10 deletions

File tree

aurelia/test__if_mocha/app.spec.ext

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe('Component app', () => {
2323
it('should render message', done => {
2424
component.create(bootstrap).then(() => {
2525
const view = component.element;
26-
expect(view.textContent.trim()).to.be('Hello Aurelia!');
26+
expect(view.textContent.trim()).to.equal('Hello Aurelia!');
2727
done();
2828
}).catch(e => {
2929
done(e);

common/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,11 @@ Details in package.json -> scripts -> pretest & test.
4848

4949
Details in package.json -> scripts -> pretest & test.
5050

51-
1. no karma, no hacking, just [browser-do](https://github.com/3cp/browser-do).
52-
2. note `| tap-dot` is optional, `tap-dot` is just a tap result formatter to please the eyes.
53-
5451
## Visible browser (chrome) test
5552

5653
npm run browser-test
5754

5855
This runs in Chrome, if you want to use other browser, update package.json "browser-test" script. Read [browser-do](https://github.com/3cp/browser-do) for available browsers.
56+
57+
By default, browser-do closes the browser after tests finish, to keep browser running, use `--keep-open` option on browser-do command.
5958
// @endif

common/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
// @endif
3838

3939
// @if jasmine || tape || mocha
40-
"tap-dot": "^2.0.0",
4140
"browser-do": "^0.1.0",
4241
// @endif
4342

jasmine/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// @endif
77
},
88
"scripts": {
9-
"test": "browser-do --jasmine < dist/entry-bundle.js | tap-dot",
9+
"test": "browser-do --jasmine < dist/entry-bundle.js",
1010
"browser-test": "npm run build:test && browser-do --jasmine --browser chrome < dist/entry-bundle.js"
1111
}
1212
}

mocha/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
// @endif
88
},
99
"scripts": {
10-
"test": "browser-do --mocha < dist/entry-bundle.js | tap-dot",
10+
"test": "browser-do --mocha < dist/entry-bundle.js",
1111
"browser-test": "npm run build:test && browser-do --mocha --browser chrome < dist/entry-bundle.js"
1212
}
1313
}

react/test__if_mocha/App.spec.extx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ describe('Component App', () => {
99
const renderer = new ShallowRenderer();
1010
renderer.render(<App />);
1111
let result = renderer.getRenderOutput();
12-
expect(result.type).to.be('div');
12+
expect(result.type).to.equal('div');
1313
expect(result.props.children).to.deep.equal(
1414
<h1>Hello React!</h1>
1515
);

tape/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// @endif
77
},
88
"scripts": {
9-
"test": "browser-do --tap < dist/entry-bundle.js | tap-dot",
9+
"test": "browser-do --tap < dist/entry-bundle.js",
1010
"browser-test": "npm run build:test && browser-do --tap --browser chrome < dist/entry-bundle.js"
1111
}
1212
}

vue/test__if_mocha/App.spec.ext

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ import App from '../src/App';
55
describe('Component App', () => {
66
it('should render message', () => {
77
const wrapper = mount(App);
8-
expect(wrapper.text()).to.be('Hello Vue!');
8+
expect(wrapper.text()).to.equal('Hello Vue!');
99
});
1010
});

0 commit comments

Comments
 (0)