Add more example configs in docs #1560
Conversation
|
@dunglas I think there will be no more adjustments to this pull request. |
| Queued connections will wait indefinitely until a PHP thread is available to serve them. To prevent that, you can use the `max_wait_time` [configuration](config.md#caddyfile-config) to limit how long a request may wait for a free PHP thread before being rejected. | ||
| Additionally, you can set a reasonable [write timeout in Caddy](https://caddyserver.com/docs/caddyfile/options#timeouts). | ||
|
|
||
| Here is how to do it using environment variables: |
There was a problem hiding this comment.
Maybe we should just provide the Caddyfile snippet? Environment variables are only available with Docker images and aren't supported by default if you use a custom Caddyfile.
WDYT?
There was a problem hiding this comment.
Personally, I'm using docker-compose and not supplying a custom Caddyfile with the image. I believe many people are doing it similarly.
There was a problem hiding this comment.
I just happened to see this. The conversation here has stopped for about a month, how is the progress?
There was a problem hiding this comment.
I think we should either provide two examples everywhere (since docker-compose syntax is hard to grasp based on Caddyfile) or use different config styles as I did in this PR to show how to use both by example.
There was a problem hiding this comment.
As environnement variables are just injected in the Caddyfile, and that all FrankenPHP builds (Docker, static, Homebrew, deb, RPM...) support Caddyfile, but not always environmentally vars, I would use Caddyfile examples everywhere, and add additional examples (as GitHub markdown tips for instance) using environnement variables to do the same thing if needed.
There was a problem hiding this comment.
So, duplicating examples everywhere for different envs? Alright. Anyone who can help me with adding Caddyfile ones? Never used it :(
There was a problem hiding this comment.
6 participants
Congrats on joining PHP 🎉