fix: stream props #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamyouss
force-pushed
the
fix/stream-props-script
branch
from
1903429 to
982da33
Compare
Contributor
Author
|
Failing due to node version :( |
dunglas
approved these changes
Nov 29, 2020
Owner
|
Maybe could we just bump the node version? |
Contributor
Author
|
Bump to the latest stable version which is 14 or latest which is 15 ? |
jamyouss
force-pushed
the
fix/stream-props-script
branch
2 times, most recently
from
c72c01a to
d2a97aa
Compare
Contributor
Author
|
Bumped to the version 14 :) |
Contributor
Author
|
@dunglas if ok for you, can you release a new version ? |
dunglas
reviewed
Nov 29, 2020
jamyouss
force-pushed
the
fix/stream-props-script
branch
from
d2a97aa to
d524dad
Compare
dunglas
approved these changes
Nov 30, 2020
Owner
|
Thanks @jamyouss |
Owner
|
New release published! |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream the props instead of write.
Use case where props are too large (100 object).