APP_ENV variable defined in Dockerfile

[tcoch]

Hello @dunglas , Hello all,

I recently observed, through bug and debug, that the env variable APP_ENV is hardcoded in the Dockerfile.

So, for the production image, it automatically adds APP_ENV=prod, which is fine.

# Prod FrankenPHP image
FROM frankenphp_base AS frankenphp_prod

ENV APP_ENV=prod

However, in dev image, we have APP_ENV=dev :

# Dev FrankenPHP image
FROM frankenphp_base AS frankenphp_dev

ENV APP_ENV=dev XDEBUG_MODE=off

This env variable overrides the APP_ENV variable that is defined is my .env file in my Symfony project.
So, when using frankenphp_dev image, I'm bound to dev environment.

Problem is, I have a staging env that I created for my project. Which I cannot use, since I have APP_ENV=dev :(

Shouldn't we remove the APP_ENV definition ? At least in the frankenphp_dev image ?

[7-zete-7]

Hi @tcoch!

In this case, you can achieve the desired value of the environment variable APP_ENV in several ways:

• As you suggest, by removing the explicit declaration of this variable in the Dockerfile.
• Configure forwarding of the variable value in compose.yaml files (by adding the line APP_ENV: ${APP_ENV:-dev} to the environment attribute of the php service). This way, the value of this environment variable will be used from the .env file.
• Set the value of this environment variable explicitly when running services inside the container itself (for example: APP_ENV=test bin/console c:c)
• Set the value of this environment variable in the FrankenPHP configuration (see Caddyfile Config and frankenphp.worker.env).

[tcoch]

Hi @7-zete-7 ,

Yes indeed I have multiple solutions, I managed to find a workaround (redefining APP_ENV in the Dockerfile).
I opened this issue looking for inputs and for a generic solution, that could be beneficial for everyone.

And in that spirit, your proposition of using APP_ENV: ${APP_ENV:-dev} seems interesting !
It's adaptative to anyone and not a breaking change, I like it. I'll soon submit a PR in that way, if no one else finds anything wrong with that.