Skip to content

Incorrect ViewProps/CustomViewProps types #163

@scriptex

Description

@scriptex

Based on the latest (v2.0.0) release, the CHANGELOG states that

Views doesn't accept viewClassName prop anymore, use className instead.

This is not reflected in the ViewProps as well as in the CustomViewProps.

Please note that this is a pure TypeScript error as the compiler complains about a missing prop when I try to use className instead of viewClassName.

There is an error when used the other way around: the old viewClassName makes TypeScript happy but then the browser is not happy and warns

Warning: React does not recognize the viewClassName prop on a DOM element ...

but this is okay since this prop is clearly not intended to be used anymore.

Please fix this as it is pretty minor :)

I can also submit a PR if you wish.

P.S. Thanks for the awesome lib!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions