fix isIOS and isMobileSafari on iPads running Safari and iOS 13 #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two additional fixes related to iPads running Safari under iOS 13.
Issues: Both
isIOSandisMobileSafaricurrently returnfalsewhen called in Safari on an iPad running iOS 13.Regarding
isIOSI guess technically iOS on iPad is now called iPadOS, but this library does not seem to reference iPadOS anywhere. So to be consistent I tried to follow the same logic with this PR.The PR fixes the issues using
|| getIPad13(), as was done in the previous PR related to this: #81.I'm not sure if this is really the best way, but it gets the job done.