Skip to content

Fails on uploading favicon.ico #207

@kade-robertson

Description

@kade-robertson

When uploading a file named favicon.ico to transfer.sh through the website, you get a bunch of garbled mess (I believe it's the data for your favicon) instead of a link to the upload.

This is presumably because it makes a PUT request to https://transfer.sh/favicon.ico which isn't/shouldn't be allowed. This is on Chrome 73.0.3683.86 on Mac OS 10.14.3:

Broken WebUI

When uploading using curl it's not quite as bad, since you receive a warning:

$ curl --upload-file ./favicon.ico https://transfer.sh/favicon.ico
Warning: Binary output can mess up your terminal. Use "--output -" to tell
Warning: curl to output it to your terminal anyway, or consider "--output
Warning: <FILE>" to save to a file.

And if you follow the warning, you get:

$ curl --upload-file ./favicon.ico https://transfer.sh/favicon.ico --output -
K�(K������������������������������������¼�ý�þ�þ��������Ý� ... # goes on

Which ends up being your favicon (as suspected):

transfer.ico

There should probably be some kind of warning if uploading a file that's invalid (or some way to handle this special case, i.e. not serving your favicon on a PUT if that's possible).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions