-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate NX workspace to latest version (21.5.2) #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@mschilling 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: mschilling <7045335+mschilling@users.noreply.github.com>
Co-authored-by: mschilling <7045335+mschilling@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the NX workspace from version 20.6.3 to 21.5.2, updating Angular from 19.2.3 to 20.2.4 and Jest from 29.7.0 to 30.0.5. The migration applies 26 automatic code transformations to maintain compatibility with the latest framework versions.
- Updated all NX packages and Angular framework to latest versions
- Migrated Angular Router API from deprecated
getCurrentNavigation()tocurrentNavigationsignal - Added generator defaults and continuous mode configuration for improved development workflow
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates all dependency versions for NX 21.5.2, Angular 20.2.4, Jest 30.0.5, and related tooling |
| nx.json | Adds generator defaults configuration for Angular style guide compliance |
| apps/web/tsconfig.app.json | Updates TypeScript module resolution to 'bundler' for better build performance |
| apps/web/src/app/app.config.ts | Migrates from deprecated getCurrentNavigation() to new currentNavigation signal API |
| apps/web/project.json | Enables continuous mode for development tasks to improve watch performance |
| apps/github-receiver/project.json | Reformats tags array to single line (cosmetic change) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "typescript": "5.9.2", | ||
| "typescript-eslint": "^8.33.1", | ||
| "verdaccio": "6.1.0", | ||
| "jest-util": "30.0.5" |
Copilot
AI
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The jest-util dependency appears to be added without a clear purpose. If this is a transitive dependency that Jest 30 requires, it should be documented or removed if not needed.
| "jest-util": "30.0.5" |
This PR migrates the NX workspace from version 20.6.3 to the latest version 21.5.2, bringing significant improvements in performance, developer experience, and access to the latest Angular 20 features.
Key Updates
Framework Versions
Automatic Migrations Applied
The migration process applied 26 automatic code transformations including:
getCurrentNavigation()to the newcurrentNavigationsignal'bundler'for better build performanceBuild & Configuration Improvements
Verification
All critical functionality has been thoroughly tested:
Benefits
The migration followed NX best practices by updating one major version at a time and applying all recommended migrations automatically while preserving existing functionality.
Fixes #191.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.