chore: improve POST /cronjobs/index-engagement-messages
#609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add debug logging and fix logic for private channel message fetching.
thanhnguyen2187
requested review from
huynguyenh,
lmquang and
namnhce
as code owners
namnhce
approved these changes
Jun 15, 2023
namnhce
added a commit
that referenced
this pull request
Jun 15, 2023
* release/v0.1.19: chore: improve POST `/cronjobs/index-engagement-messages` (#609)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
/cronjobs/index-engagement-messagesIn the handler implementation:
A new logic like that is needed to handle the case when Dwarves Discord Bot tries to fetch messages from a private channel where it does not have access to.
Sample warning log:
{"channelID":"1118565478613397614","cursorMessageID":"0","guildID":"957918098403520532","level":"warning","msg":"get messages after cursor error: HTTP 403 Forbidden, {\"message\": \"Missing Access\", \"code\": 50001}","time":"2023-06-14T22:57:30+07:00"}What are the relevant Git tickets?
Screenshots (if appropriate)
Any background context you want to provide? (if appropriate)