Removed material ui from progress bar component #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixed bug:
Added a fix to remove this margin when no helper text defined. |
marcialfps
requested changes
Aug 2, 2022
Collaborator
marcialfps
left a comment
marcialfps
left a comment
There was a problem hiding this comment.
Other comments:
- Take a look at accessibility recommendations, I think we need some attributes like
aria-busy.
added 2 commits
August 2, 2022 11:55
Contributor
Author
|
Found bug with |
marcialfps
requested changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Remove Material UI dependencies from Progress Bar #1190