Skip to content

Conversation

@GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Oct 21, 2022

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
To avoid passing some specific props that could be potentially HTML attributes, styled-components offer what they called transient props. These are regular props marked with the symbol $ so the library understands that they shouldn't be passed to the underlying component.

Screenshots
image

Additional context
What transient props are
https://medium.com/@probablyup/introducing-transient-props-f35fd5203e0c
https://dev.to/sarahscode/props-are-not-forever-preventing-props-from-being-passed-to-the-dom-with-styled-components-v5-1-l47

Closes #1343

@GomezIvann
Copy link
Collaborator Author

GomezIvann commented Oct 24, 2022

Also, I fixed a small error caught during validation in the Text Input styles, which were rendering false; when hovered:

image

image

@aidamag aidamag self-assigned this Oct 24, 2022
@aidamag aidamag merged commit e26622f into master Oct 25, 2022
@aidamag aidamag deleted the gomezivann-flex-fix branch October 25, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong attributes appearing in Flex HTML outcome

3 participants