Update default rate limit params for USDC

[teddyding]

Changelist

Update rate limit params per discussion with research (thread):

max(1% of TVL, $1mm) per hour
AND
max(10% of TVL, $10mm) per day

Test Plan

Unit tests

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

[coderabbitai]

Important

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The recent updates involve adjusting the baseline limits for rate-limiting within a blockchain protocol. Specifically, the changes increase the minimum baseline values for rate-limiters, enhancing the thresholds for 1-hour and 1-day limits from 100k and 1m USDC to 1m and 10m USDC respectively. This adjustment reflects a significant increase in the capacity for transaction rate-limiting, aiming to accommodate larger volumes of transactions.

Changes

Files	Change Summary
.../testutil/constants/genesis.go	Updated GenesisState to increase baseline_minimum values for two limiters.
.../x/ratelimit/types/params.go	Adjusted baseline USDC values for 1-hour and 1-day rate limits from 100k and 1m to 1m and 10m.
.../x/ratelimit/types/params_test.go	Updated BaselineMinimum values in tests to align with new rate-limiting thresholds.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between d31fa07 and bc38c79.

Files ignored due to path filters (2)

• protocol/app/testdata/default_genesis_state.json is excluded by: !**/*.json
• protocol/scripts/genesis/sample_pregenesis.json is excluded by: !**/*.json

Files selected for processing (3)

• protocol/testutil/constants/genesis.go (1 hunks)
• protocol/x/ratelimit/types/params.go (1 hunks)
• protocol/x/ratelimit/types/params_test.go (1 hunks)

Additional comments: 6

protocol/x/ratelimit/types/params_test.go (2)

• 19-19: The BaselineMinimum value for the 1-hour limiter has been updated to 1_000_000_000_000. Confirm this aligns with the intended rate limit adjustments.
• 24-24: The BaselineMinimum value for the 1-day limiter has been updated to 10_000_000_000_000. Ensure this change matches the protocol's updated rate limiting strategy.

protocol/x/ratelimit/types/params.go (2)

• 16-16: The BigBaselineMinimum1Hr value has been updated to 1_000_000. Verify the calculation correctly accounts for the USDC denomination exponent.
• 22-22: The BigBaselineMinimum1Day value has been updated to 10_000_000. Confirm the calculation is accurate, considering the USDC denomination exponent.

protocol/testutil/constants/genesis.go (2)

• 1369-1369: The baseline_minimum value for the 1-hour limiter has been updated from 100000000000 to 1000000000000. Ensure this tenfold increase aligns with the intended rate limit adjustments for USDC transactions.
• 1374-1374: The baseline_minimum value for the 1-day limiter has been updated from 1000000000000 to 10000000000000. Confirm this tenfold increase is consistent with the desired changes for managing USDC transaction volumes over a 1-day period.

[teddyding]

@Mergifyio backport release/protocol/v4.x

[mergify]

backport release/protocol/v4.x

✅ Backports have been created

• #1057 Update default rate limit params for USDC (backport #1056) has been created for branch release/protocol/v4.x