Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(subaccount-transfer): enforce senderAddress matches localWallet #703

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix(subaccount-transfer): enforce senderAddress matches localWallet #703

merged 1 commit into from
Jun 20, 2024

Conversation

jaredvu
Copy link
Contributor

@jaredvu jaredvu commented Jun 20, 2024 •
edited
Loading

Enforce that the connected wallet matches the senderAddress from Abacus. In all isolated margin flows senderAddress === destinationAddress.

Functions

  • lib/abacus/dydxChainTransacitions
    • Utilize new senderAddress param from Abacus bump
    • Throw if localwallet.address does not match senderAdddress.

Packages

  • v4-abacus
    • updated: v1.7.87 -> v1.7.90
    • add senderAddress to HumanReadableSubaccountTransferPayload
    • for auto transfer flows
      • place isolated margin order: senderAddress matches destinationAddress
      • reclaim un-utilized child funds: senderAddress matches destinationAddress
    • adjustIsolatedMargin: senderAddress matches destinationAddress

@vercel Vercel
Copy link

vercel bot commented Jun 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 10:04pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 10:04pm

@jaredvu jaredvu merged commit a43f2a3 into main Jun 20, 2024
7 checks passed
@jaredvu jaredvu deleted the jv/enforce-sender-address-match branch June 20, 2024 22:07
This was referenced Jun 21, 2024
Merged
Merged
Merged
Merged
DavideSegullo added a commit to nabla-studio/v4-web that referenced this pull request Jun 26, 2024
@DavideSegullo @moo-onthelawn
@jaredvu @aforaleka @rosepuppy @yogurtandjam @yujin512 @tqin7 @tyleroooo
Nabla/feat export csv v2 (#3)
4365635 
* feat: ➕ add export-to-csv dep

* feat: ✨ add download icon

* feat: ✨ add navigation menu slots

* feat: ✨ add csv utility

* feat: 🏷️ improve dropdown menu types

* refactor: ♻️ refactor Output component

refactored Output component to export formatting utils.

* feat: ✨ add ExportHistoryDropdown component

* feat: ✨ add export inside History page

added ExportHistoryDropdown component inside History page layout.

* feat: 🚸 disable csv export on empty data

* feat: 📈 add export history analytics

* fix: 🐛 fix export history download

* fix: 🐛 fix post merge errors

* feat: ✨ add reusable format number function

* refactor: ♻️ add better style declaration

* fix: 🐛 fix post merge errors

* fix: 🐛 fix react errors

* fix: 🐛 fix empty export

* feat: ⬆️ upgrade @dydxprotocol/v4-client-js

* feat: ✨ add history export all services

* feat: ✨ add export loading states

* refactor: 🎨 improve format of the code

* style: 🚨 fix lint errors

* style: 🚨 add default case

* feat: ✨ add export sorting in decreasing order

* feat: ✨ add price column inside csv

* fix: add back precision to earned by stakers (dydxprotocol#692)

* fix(sparklines): bump abacus and fix output component (dydxprotocol#695)

* feat(staking): ui of validator selection (dydxprotocol#691)

* chore: replace spread row with mid market price row (dydxprotocol#696)

* chore(hide-gasToggle): temp hide gas toggle (dydxprotocol#700)

* chore: improve order statuses (dydxprotocol#693)

* fix(subaccount-transfer): enforce senderAddress matches localWallet (dydxprotocol#703)

* feat: update to use proxy for staking apr (dydxprotocol#702)

* chore: remove deprecated params [OTE-353] (dydxprotocol#698)

* feat: add ZK, ZRO, NCAT to the widget (dydxprotocol#704)

* feat(staking): polishes (dydxprotocol#701)

* feat: improve markets page style (dydxprotocol#699)

* feat: ⬆️ upgrade @dydxprotocol/v4-client-js

* feat: ✨ add parentSubaccount export

* feat: ✨ disable export on disconnection state

* feat(staking): add staking live notif (dydxprotocol#708)

* feat(new market): have other market validation run on diff only (dydxprotocol#705)

* feat: redirect other reward pages after staking is turned on (dydxprotocol#711)

* docs: 📝 improve comment format

* fix: 🐛 fix merge error

* style: 🚨 fix lint errors

* feat: fix invert tag for certain raydium markets (dydxprotocol#709)

Co-authored-by: jaredvu <jaredvu@gmail.com>

* chore(default-page): change default page to /markets (dydxprotocol#713)

* chore(staking): remove last faq question (dydxprotocol#712)

* feat: add tracking to staking (dydxprotocol#710)

* fix: polishes for staking (dydxprotocol#716)

* fix: nonzero rewards (dydxprotocol#653)

* chore: fully type dialogs, fix some more any types, redo analytics (dydxprotocol#671)

* fix: fix validator url icon (dydxprotocol#720)

* chore(new-market): update header copy (dydxprotocol#718)

* feat(mobile-download): Add mobile app store download links (dydxprotocol#717)

* feat: preload metadata for all markets in otherMarketData.json (dydxprotocol#646)

Co-authored-by: jaredvu <jaredvu@gmail.com>

* fix: isolated positions bug fixes + auto-open (dydxprotocol#721)

* feat: orderbook refresh + updates (dydxprotocol#647)

* chore: install-local-l10n command (dydxprotocol#697)

* chore: use FormMaxInputToggleButton in transfer/deposit/withdraw forms (dydxprotocol#715)

* fix: fix updated terms of use link (dydxprotocol#724)

* fix: orderbook bugs (dydxprotocol#725)

* style(nits): update exchange billboards and stats, assetIcons (dydxprotocol#726)

* feat: update zk logo and zro zk logo data (dydxprotocol#727)

* feat: skip track/status endpoints [OTE-354] (dydxprotocol#719)

* fix(disconnect-cleanup): set localWallet and hdKey to undefined when disconnecting (dydxprotocol#728)

* fix: analytics property names (dydxprotocol#730)

* style(tables): update table header styling (dydxprotocol#729)

* feat: ✨ add new analytics api

---------

Co-authored-by: moo-onthelawn <70078372+moo-onthelawn@users.noreply.github.com>
Co-authored-by: Jared Vu <jaredvu@gmail.com>
Co-authored-by: aleka <aforaleka@gmail.com>
Co-authored-by: Bill <bill@dydx.exchange>
Co-authored-by: Jeremy Lee <37092291+yogurtandjam@users.noreply.github.com>
Co-authored-by: yujin512 <yujin@dydx.exchange>
Co-authored-by: Tian <tian@dydx.exchange>
Co-authored-by: tyleroooo <tyler@dydx.exchange>
DavideSegullo pushed a commit to nabla-studio/v4-web that referenced this pull request Jun 26, 2024
@jaredvu @DavideSegullo
fix(subaccount-transfer): enforce senderAddress matches localWallet (d…
7038de4 
…ydxprotocol#703)
DavideSegullo pushed a commit to nabla-studio/v4-web that referenced this pull request Jun 26, 2024
@jaredvu @DavideSegullo
fix(subaccount-transfer): enforce senderAddress matches localWallet (d…
e256ae8 
…ydxprotocol#703)
DavideSegullo added a commit to nabla-studio/v4-web that referenced this pull request Jun 28, 2024
@DavideSegullo
docs: 📝 improve comment format
9d9e088 
chore: override post order position margin for full close position on isolated market (dydxprotocol#670)

fix: fix decimal places on order size/amount in positions + orders table (dydxprotocol#675)

chore(staking): (un)stake form polishes (dydxprotocol#658)

chore: set privy app client id (dydxprotocol#660)

fix: handle partially canceled orders (dydxprotocol#679)

fix(staking): add faq + fix unflagged fetch of trading rewards data (dydxprotocol#681)

feat: cancel trigger orders automatically / abacus bump (dydxprotocol#682)

chore: abacus enum casing + remove cancelOrder param (dydxprotocol#683)

chore(adjust-margin): add additional validation (dydxprotocol#668)

chore(abacus): bump to 1.7.83 (dydxprotocol#677)

Co-authored-by: aforaleka <aforaleka@gmail.com>

feat: add raydium markets to the widget (dydxprotocol#533)

Co-authored-by: jaredvu <jaredvu@gmail.com>
Co-authored-by: Bill <bill@dydx.exchange>
Co-authored-by: tyleroooo <tyler@dydx.exchange>
Co-authored-by: moo-onthelawn <70078372+moo-onthelawn@users.noreply.github.com>
Co-authored-by: Tian Qin <tian@dydx.exchange>
Co-authored-by: Nikhil Vasan <97126437+nivasan1@users.noreply.github.com>

fix(new-market-filter): remove isolated filter (dydxprotocol#688)

feat(staking): claim rewards transaction (+ simulation) (dydxprotocol#648)

fix: Recently Listed Markets View Sorted by `clobPairId` (dydxprotocol#689)

chore: bump abacus (dydxprotocol#690)

feat: share PNL analytics (dydxprotocol#678)

fix: add back precision to earned by stakers (dydxprotocol#692)

fix(sparklines): bump abacus and fix output component (dydxprotocol#695)

feat(staking): ui of validator selection (dydxprotocol#691)

chore: replace spread row with mid market price row (dydxprotocol#696)

chore(hide-gasToggle): temp hide gas toggle (dydxprotocol#700)

chore: improve order statuses (dydxprotocol#693)

fix(subaccount-transfer): enforce senderAddress matches localWallet (dydxprotocol#703)

feat: update to use proxy for staking apr (dydxprotocol#702)

chore: remove deprecated params [OTE-353] (dydxprotocol#698)

feat: add ZK, ZRO, NCAT to the widget (dydxprotocol#704)

feat(staking): polishes (dydxprotocol#701)

feat: improve markets page style (dydxprotocol#699)

feat(staking): add staking live notif (dydxprotocol#708)

feat(new market): have other market validation run on diff only (dydxprotocol#705)

feat: redirect other reward pages after staking is turned on (dydxprotocol#711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moo-onthelawn moo-onthelawn moo-onthelawn approved these changes

@rosepuppy rosepuppy rosepuppy approved these changes

@aforaleka aforaleka Awaiting requested review from aforaleka

@yogurtandjam yogurtandjam Awaiting requested review from yogurtandjam

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaredvu @rosepuppy @moo-onthelawn