-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skip track/status endpoints [OTE-354] #719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yogurtandjam
force-pushed
the
jerms/OTE-354_track-skip
branch
from
June 25, 2024 15:08
5427d87
to
5577942
Compare
yogurtandjam
force-pushed
the
jerms/OTE-354_track-skip
branch
from
June 25, 2024 15:12
5577942
to
e11a70f
Compare
yogurtandjam
changed the title
Jerms/ote 354 track skip
feat: skip track/status endpoints [OTE-354]
Jun 25, 2024
yogurtandjam
force-pushed
the
jerms/OTE-354_track-skip
branch
from
June 25, 2024 15:25
e11a70f
to
6fc64d9
Compare
yogurtandjam
force-pushed
the
jerms/OTE-354_track-skip
branch
from
June 25, 2024 15:35
6fc64d9
to
a7b35c6
Compare
yogurtandjam
force-pushed
the
jerms/OTE-354_track-skip
branch
from
June 25, 2024 15:51
a7b35c6
to
1e54429
Compare
yogurtandjam
force-pushed
the
jerms/OTE-354_track-skip
branch
2 times, most recently
from
June 25, 2024 17:10
7ef21af
to
db7a97a
Compare
yogurtandjam
force-pushed
the
jerms/OTE-354_track-skip
branch
from
June 25, 2024 17:12
db7a97a
to
b406972
Compare
yogurtandjam
force-pushed
the
jerms/OTE-354_track-skip
branch
from
June 25, 2024 19:36
717a9dd
to
cae6df2
Compare
yogurtandjam
force-pushed
the
jerms/OTE-354_track-skip
branch
2 times, most recently
from
June 25, 2024 21:06
87143ae
to
d70def9
Compare
rosepuppy
approved these changes
Jun 25, 2024
fix fix lockfile fixing. only add skip. test jsdom separately attempt reinstall fix reisntall skip add jsdom
yogurtandjam
force-pushed
the
jerms/OTE-354_track-skip
branch
from
June 25, 2024 22:02
d70def9
to
d1d19d2
Compare
DavideSegullo
added a commit
to nabla-studio/v4-web
that referenced
this pull request
Jun 26, 2024
* feat: ➕ add export-to-csv dep * feat: ✨ add download icon * feat: ✨ add navigation menu slots * feat: ✨ add csv utility * feat: 🏷️ improve dropdown menu types * refactor: ♻️ refactor Output component refactored Output component to export formatting utils. * feat: ✨ add ExportHistoryDropdown component * feat: ✨ add export inside History page added ExportHistoryDropdown component inside History page layout. * feat: 🚸 disable csv export on empty data * feat: 📈 add export history analytics * fix: 🐛 fix export history download * fix: 🐛 fix post merge errors * feat: ✨ add reusable format number function * refactor: ♻️ add better style declaration * fix: 🐛 fix post merge errors * fix: 🐛 fix react errors * fix: 🐛 fix empty export * feat: ⬆️ upgrade @dydxprotocol/v4-client-js * feat: ✨ add history export all services * feat: ✨ add export loading states * refactor: 🎨 improve format of the code * style: 🚨 fix lint errors * style: 🚨 add default case * feat: ✨ add export sorting in decreasing order * feat: ✨ add price column inside csv * fix: add back precision to earned by stakers (dydxprotocol#692) * fix(sparklines): bump abacus and fix output component (dydxprotocol#695) * feat(staking): ui of validator selection (dydxprotocol#691) * chore: replace spread row with mid market price row (dydxprotocol#696) * chore(hide-gasToggle): temp hide gas toggle (dydxprotocol#700) * chore: improve order statuses (dydxprotocol#693) * fix(subaccount-transfer): enforce senderAddress matches localWallet (dydxprotocol#703) * feat: update to use proxy for staking apr (dydxprotocol#702) * chore: remove deprecated params [OTE-353] (dydxprotocol#698) * feat: add ZK, ZRO, NCAT to the widget (dydxprotocol#704) * feat(staking): polishes (dydxprotocol#701) * feat: improve markets page style (dydxprotocol#699) * feat: ⬆️ upgrade @dydxprotocol/v4-client-js * feat: ✨ add parentSubaccount export * feat: ✨ disable export on disconnection state * feat(staking): add staking live notif (dydxprotocol#708) * feat(new market): have other market validation run on diff only (dydxprotocol#705) * feat: redirect other reward pages after staking is turned on (dydxprotocol#711) * docs: 📝 improve comment format * fix: 🐛 fix merge error * style: 🚨 fix lint errors * feat: fix invert tag for certain raydium markets (dydxprotocol#709) Co-authored-by: jaredvu <jaredvu@gmail.com> * chore(default-page): change default page to /markets (dydxprotocol#713) * chore(staking): remove last faq question (dydxprotocol#712) * feat: add tracking to staking (dydxprotocol#710) * fix: polishes for staking (dydxprotocol#716) * fix: nonzero rewards (dydxprotocol#653) * chore: fully type dialogs, fix some more any types, redo analytics (dydxprotocol#671) * fix: fix validator url icon (dydxprotocol#720) * chore(new-market): update header copy (dydxprotocol#718) * feat(mobile-download): Add mobile app store download links (dydxprotocol#717) * feat: preload metadata for all markets in otherMarketData.json (dydxprotocol#646) Co-authored-by: jaredvu <jaredvu@gmail.com> * fix: isolated positions bug fixes + auto-open (dydxprotocol#721) * feat: orderbook refresh + updates (dydxprotocol#647) * chore: install-local-l10n command (dydxprotocol#697) * chore: use FormMaxInputToggleButton in transfer/deposit/withdraw forms (dydxprotocol#715) * fix: fix updated terms of use link (dydxprotocol#724) * fix: orderbook bugs (dydxprotocol#725) * style(nits): update exchange billboards and stats, assetIcons (dydxprotocol#726) * feat: update zk logo and zro zk logo data (dydxprotocol#727) * feat: skip track/status endpoints [OTE-354] (dydxprotocol#719) * fix(disconnect-cleanup): set localWallet and hdKey to undefined when disconnecting (dydxprotocol#728) * fix: analytics property names (dydxprotocol#730) * style(tables): update table header styling (dydxprotocol#729) * feat: ✨ add new analytics api --------- Co-authored-by: moo-onthelawn <70078372+moo-onthelawn@users.noreply.github.com> Co-authored-by: Jared Vu <jaredvu@gmail.com> Co-authored-by: aleka <aforaleka@gmail.com> Co-authored-by: Bill <bill@dydx.exchange> Co-authored-by: Jeremy Lee <37092291+yogurtandjam@users.noreply.github.com> Co-authored-by: yujin512 <yujin@dydx.exchange> Co-authored-by: Tian <tian@dydx.exchange> Co-authored-by: tyleroooo <tyler@dydx.exchange>
DavideSegullo
pushed a commit
to nabla-studio/v4-web
that referenced
this pull request
Jun 26, 2024
DavideSegullo
pushed a commit
to nabla-studio/v4-web
that referenced
this pull request
Jun 26, 2024
This was referenced Jun 26, 2024
DavideSegullo
added a commit
to nabla-studio/v4-web
that referenced
this pull request
Jun 28, 2024
feat: fix invert tag for certain raydium markets (dydxprotocol#709) Co-authored-by: jaredvu <jaredvu@gmail.com> chore(default-page): change default page to /markets (dydxprotocol#713) chore(staking): remove last faq question (dydxprotocol#712) feat: add tracking to staking (dydxprotocol#710) fix: polishes for staking (dydxprotocol#716) fix: nonzero rewards (dydxprotocol#653) chore: fully type dialogs, fix some more any types, redo analytics (dydxprotocol#671) fix: fix validator url icon (dydxprotocol#720) chore(new-market): update header copy (dydxprotocol#718) feat(mobile-download): Add mobile app store download links (dydxprotocol#717) feat: preload metadata for all markets in otherMarketData.json (dydxprotocol#646) Co-authored-by: jaredvu <jaredvu@gmail.com> fix: isolated positions bug fixes + auto-open (dydxprotocol#721) feat: orderbook refresh + updates (dydxprotocol#647) chore: install-local-l10n command (dydxprotocol#697) chore: use FormMaxInputToggleButton in transfer/deposit/withdraw forms (dydxprotocol#715) fix: fix updated terms of use link (dydxprotocol#724) fix: orderbook bugs (dydxprotocol#725) style(nits): update exchange billboards and stats, assetIcons (dydxprotocol#726) feat: update zk logo and zro zk logo data (dydxprotocol#727) feat: skip track/status endpoints [OTE-354] (dydxprotocol#719) fix(disconnect-cleanup): set localWallet and hdKey to undefined when disconnecting (dydxprotocol#728) fix: analytics property names (dydxprotocol#730) style(tables): update table header styling (dydxprotocol#729)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by: https://github.com/dydxprotocol/v4-abacus/pull/471/files
This PR adds functionality for skip's track and status endpoints.
We unfortunately need a lot of code in order to make the skip payload consumable and swappable with the existing squid code. We decided to go this route to ensure we localize all the logic into one area.
Once we remove squid completely, we can begin refactoring our skip code to be more 'true' to its API. This will likely come hand in hand with 2 other things:
This PR also adds a lot of test code. The tests are there to ensure that through various payloads, we transform the skip payload to look functionally identical to the squid code. The doc describing the payload transformation is here: https://www.notion.so/dydx/Squid-Skip-Status-endpoint-1a15bd2cb45c4ccfbc0b095986ef4f09
Constants/Types
public/configs/v1/env.json
Hooks
src/hooks/useLocalNotifications.tsx
fetchSquidStatus
forfetchTransactionStatus
src/hooks/useEndpointsConfig.ts
src/hooks/useNotificationTypes.tsx
Functions
lib/squid
fetchSkipStatus
- retrieves tx status from skip endpointtrackSkipTx
- posts to skip track endpoint to track a txfetchTransferStatus
- retrieves either transfer status using either skip or squid endpointclass TransactionData
- consumes all relevant data necessary to create either a route status entry or a from/toChain entry. the reason why we do thisPackages
jsdom
window