common-dylan-test-suite: don't do output to terminal #1681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is still one call to debug-message("Hello") but I don't know if capturing its
output is doable.
housel
approved these changes
Mar 27, 2025
fraya
approved these changes
Sep 9, 2025
|
|
||
|
|
||
| define constant *print-lock* = make(<lock>); | ||
| define constant $debug-threads-tests = #f; |
There was a problem hiding this comment.
I don't understand why this is used. Is a constant and is not used in another place, so is like the block below is not gonna be executed. I could understand if is a define thread variable. Can you explain me why?
There was a problem hiding this comment.
It could be a variable instead. It's just that I found it hard to imagine someone entering the interactor/debugger, setting the variable, and then running the tests.
There was a problem hiding this comment.
So it really just provides a way to make a one-letter change (f -> t) to see the output if desired. It would've been fine to just delete the output code entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still one call to debug-message("Hello") but I don't know if capturing its output is doable.