Skip to content

Vrushalpatilbranch#115

Merged
jvondermarck merged 3 commits intojvondermarck:mainfrom
itsVrushal:vrushalpatilbranch
Dec 24, 2024
Merged

Vrushalpatilbranch#115
jvondermarck merged 3 commits intojvondermarck:mainfrom
itsVrushal:vrushalpatilbranch

Conversation

@itsVrushal
Copy link
Copy Markdown

πŸ‘‰ Checklist

Please make sure to check off the following before submitting:

  • [ x] I have reviewed my submission thoroughly.
  • [x ] I have tested my code (if submission is related to coding) and run the game before pushing (to make sure the project compile).
  • [ x] I have run the JUnit tests (if submission is related to coding).
  • [ x] I have read the Code of Conduct and Contribution Guidelines.

✍ Description of the Pull Request

Please concisely describe the changes you have made.
I have added languages like German, French, Russian, Spanish to all the UI on the game except for the pause menu.

πŸ”— Issue link

Issue reference number and link goes here e.g. 'Fixes/Closes ' #99.
#99


Thanks for taking the time to fill out this Pull Request! ❀️ Thanks for contributing to this project πŸ¦–

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹ Hello @itsVrushal, thank you for submitting in Dinosaur Exploder πŸ¦– PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • βœ… Verify your PR is up-to-date with the repository /dinosaur-exploder main branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • βœ… Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
  • βœ… Verify that you have well fill out the different checkboxes in the PR template.
  • ⚠️ Check that your code is clean: no code redundancy, variable and method names are correct, your code is understandable to everyone, and so on.
  • πŸ’‘ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

Copy link
Copy Markdown
Owner

@jvondermarck jvondermarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and so sorry for the delay :(

@jvondermarck jvondermarck merged commit 3fd8a57 into jvondermarck:main Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: add internationalization 🌍

3 participants