Skip to content

new feature: sideway movement animation#80

Merged
jvondermarck merged 1 commit intojvondermarck:mainfrom
gabrielaramburu:sideway-movement-animation
Jul 22, 2022
Merged

new feature: sideway movement animation#80
jvondermarck merged 1 commit intojvondermarck:mainfrom
gabrielaramburu:sideway-movement-animation

Conversation

@gabrielaramburu
Copy link
Copy Markdown
Contributor

👉 Checklist

Please make sure to check off the following before submitting:

  • [x ] I have reviewed my submission thoroughly.
  • [x ] I have tested my code (if submission is related to coding) and run the game before pushing (to make sure the project compile).
  • [ x] I have run the JUnit tests (if submission is related to coding).
  • [x ] I have read the Code of Conduct and Contribution Guidelines.

✍ Description of the Pull Request

I have implemented the sideway animation of the spaceship.

imagen

🔗 Issue link

Issue reference number and link goes here e.g. 'Fixes/Closes #<issue_number>'.

  • This Pull Request fixes the issue : 'Closes #'
  • [ X] This Pull Request does not fix an issue.

Thanks for taking the time to fill out this Pull Request! ❤️ Thanks for contributing to this project 🦖

@jvondermarck
Copy link
Copy Markdown
Owner

Well done, thank you so much for your work ! And sorry for the late review of your PR.

@jvondermarck jvondermarck merged commit 1d905c6 into jvondermarck:main Jul 22, 2022
@gabrielaramburu
Copy link
Copy Markdown
Contributor Author

No problem, I think the animation can be improved if other image (I put the image of the ship without any modification) is used in the shadow.
best regards

@jvondermarck
Copy link
Copy Markdown
Owner

The animation looks really good, you still can make some updates if you want, you're free to do everything you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants