Skip to content

[Feature]: Update the life system design#84

Merged
jvondermarck merged 1 commit intojvondermarck:mainfrom
singhparmeetb:my-dedmondium-contribution
Oct 15, 2022
Merged

[Feature]: Update the life system design#84
jvondermarck merged 1 commit intojvondermarck:mainfrom
singhparmeetb:my-dedmondium-contribution

Conversation

@singhparmeetb
Copy link
Copy Markdown
Contributor

👉 Checklist

Please make sure to check off the following before submitting:

  • I have reviewed my submission thoroughly.
  • I have tested my code (if submission is related to coding) and run the game before pushing (to make sure the project compile).
  • I have run the JUnit tests (if submission is related to coding).
  • I have read the Code of Conduct and Contribution Guidelines.

✍ Description of the Pull Request

Added a redesigned Lives system with hearts instead of plain numbers

Please concisely describe the changes you have made.

First of all, sorry for soo many chances, these were actually made by VS Code auto code beautifier; Hence a lot of indentation and other difference. But the major change is in only 2 files, namely

LifeComponent.Java and DinosaurController.Java

from lines 14-63 and 29-31 respectively

The first change consists of a basic code block which checks the life variable and accordingly shows/deletes the hearts.

The edit in the second file was done so that the hearts can update even after the player is lost; Because otherwise we can still see one heart lingering around from the end menu. The code makes the game to update the score even after being lost and hence there are 0 hearts after being lost.

🔗 Issue link

Issue reference number and link goes here e.g. 'Fixes/Closes #60 '.

  • This Pull Request fixes the issue : 'Closes #'
  • This Pull Request does not fix an issue.

Thanks for taking the time to fill out this Pull Request! ❤️ Thanks for contributing to this project 🦖

@singhparmeetb singhparmeetb marked this pull request as draft October 14, 2022 20:54
@singhparmeetb singhparmeetb marked this pull request as ready for review October 14, 2022 20:55
@singhparmeetb
Copy link
Copy Markdown
Contributor Author

Sorry for the weird PR name💀.
I was testing out the PR data and submitted and later saw the name

@singhparmeetb
Copy link
Copy Markdown
Contributor Author

Again, sorry for closing this branch accidently💀
Just newbie errors

@jvondermarck jvondermarck changed the title Test [Feature]: Update the life system design Oct 15, 2022
@jvondermarck
Copy link
Copy Markdown
Owner

Hi, it's awesome, great work !! Thank you. Feel free to create new issues in the project to still continue improve the game. Thanks.

@jvondermarck jvondermarck merged commit 359fa14 into jvondermarck:main Oct 15, 2022
@singhparmeetb
Copy link
Copy Markdown
Contributor Author

Thank you soo much. This counts as my first ever opensource contribution and I am glad it was this game.
Once again, a huge thanks for being soo helpful and supportive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Update the life system design

2 participants