Created a class to hold the constants#98
Merged
jvondermarck merged 2 commits intojvondermarck:mainfrom Aug 13, 2023
Merged
Conversation
Contributor
There was a problem hiding this comment.
👋 Hello @MelissaAyllon, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with the repository
/dinosaur-explodermainbranch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pullandgit merge masterlocally. - ✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
- ✅ Verify that you have well fill out the different checkboxes in the PR template.
- 💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee
jvondermarck
approved these changes
Aug 13, 2023
Owner
jvondermarck
left a comment
There was a problem hiding this comment.
Hi @MelissaAyllon ! Really good contribution, the code is clean, so everything is perfect ! Congrats ! 🎉
Contributor
Author
|
Thankss for the merge, It was my first contribution😊 |
Owner
|
It was a pleasure @MelissaAyllon to review your first contribution in the world of Open Source projects ! Feel free to work on the other opened issues or create new issues to improve our game and repository ! 😘 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👉 Checklist
✍ Description of the Pull Request
🔗 Issue link