Skip to content

Created a class to hold the constants#98

Merged
jvondermarck merged 2 commits intojvondermarck:mainfrom
MelissaAyllon:main
Aug 13, 2023
Merged

Created a class to hold the constants#98
jvondermarck merged 2 commits intojvondermarck:mainfrom
MelissaAyllon:main

Conversation

@MelissaAyllon
Copy link
Copy Markdown
Contributor

👉 Checklist

Please make sure to check off the following before submitting:

  • [✅ ] I have reviewed my submission thoroughly.
  • [✅ ] I have tested my code (if submission is related to coding) and run the game before pushing (to make sure the project compile).
  • [❌ ] I have run the JUnit tests (if submission is related to coding).
  • [✅ ] I have read the Code of Conduct and Contribution Guidelines.

✍ Description of the Pull Request

Please concisely describe the changes you have made.

  • I have created the GameConstants class for each constant that was repeated many times in the code
  • I have created a method called entityBuilderBase in GameEntityFactory class, to separate some of the code that is repeated in that class
  • In LifeComponent class, I refactored a piece of code in the method onUpdate with consolidate Duplicate Conditional Fragments technique.

🔗 Issue link

Issue reference number and link goes here e.g. 'Fixes/Closes #<issue_number>'.


Thanks for taking the time to fill out this Pull Request! ❤️ Thanks for contributing to this project 🦖

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @MelissaAyllon, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify your PR is up-to-date with the repository /dinosaur-exploder main branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • ✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
  • ✅ Verify that you have well fill out the different checkboxes in the PR template.
  • 💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

Copy link
Copy Markdown
Owner

@jvondermarck jvondermarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MelissaAyllon ! Really good contribution, the code is clean, so everything is perfect ! Congrats ! 🎉

@jvondermarck jvondermarck merged commit 10ab972 into jvondermarck:main Aug 13, 2023
@MelissaAyllon
Copy link
Copy Markdown
Contributor Author

Thankss for the merge, It was my first contribution😊

@jvondermarck
Copy link
Copy Markdown
Owner

It was a pleasure @MelissaAyllon to review your first contribution in the world of Open Source projects ! Feel free to work on the other opened issues or create new issues to improve our game and repository ! 😘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor]: creating a class to hold all constants

2 participants