feat(middleware): remove info log from log middleware

fixes #56

commit 9a075fe
Author: Dylan Foster <dylan947@gmail.com>
Date:   Sat Nov 11 20:06:03 2017 -0800

    feat(middleware): update after log

commit f8dd114
Author: Dylan Foster <dylan947@gmail.com>
Date:   Sat Nov 11 19:52:11 2017 -0800

    feat(middleware): remove info log from log middleware

    fixes #56

Author: dylanfoster

src/initializers/middleware.js

@@ -47,8 +47,13 @@ module.exports = {
 
     middlewares.unshift(logger({ log: application.logger }));
     middlewares.push(context(application));
+
     app.on("after", (req, res, route, err) => {
-      req.log.info({ req, res, err });
+      if (err) {
+        req.log.error({ req, res, err });
+      } else {
+        req.log.info({ req, res, err });
+      }
     });
     middlewares.forEach(middlware => { app.use(middlware); });
   },

src/middleware/logger.js

@@ -4,7 +4,6 @@ export default function (options) {
   return function logger(req, res, next) {
     const log = options.log;
 
-    log.child({ reqID: req.getId() }).info({ req, res });
     req.log = log.child({ reqID: req.getId() });
     next();
   };

test/application_tests.js

@@ -256,155 +256,6 @@ describe("Application", function () {
     });
   });
 
-  describe("logging", function () {
-    let loggingDir, messages, writable;
-
-    beforeEach(function () {
-      loggingDir = path.resolve(__dirname, "fixtures/custom-logs");
-      messages = [];
-      stream.write = message => {
-        messages.push(JSON.parse(message));
-      };
-    });
-
-    afterEach(function () {
-      return del([`${loggingDir}/**/*.log`, `!${loggingDir}`]);
-    });
-
-    it("allows for a custom directory", function (done) {
-      application = new Application({
-        controllers: {
-          dir: path.resolve(__dirname, "fixtures", "controllers")
-        },
-        database: {
-          connection,
-          models: { dir: path.resolve(__dirname, "fixtures/models") }
-        },
-        logging: {
-          dir: loggingDir
-        },
-        serializers: {
-          dir: path.resolve(__dirname, "fixtures", "serializers")
-        }
-      });
-
-      application.map(function () {
-        this.resource("user");
-      });
-
-      supertest(application.getApp())
-        .get("/users")
-        .end(function (err, res) {
-          if (err) { return done(err); }
-
-          fs.readdir(loggingDir, (err2, files) => {
-            if (err2) { return done(err2); }
-
-            const file = files.filter(f => f.match(/\.log/));
-            let log;
-
-            expect(file).to.be.ok;
-            expect(file).to.have.length.gt(0);
-
-            const fileData = fs.readFileSync(path.resolve(loggingDir, file[0]));
-            const lines = fileData
-              .toString()
-              .split("\n")
-              .filter(line => line.length);
-            const line = lines[lines.length - 1];
-
-            try {
-              log = JSON.parse(line);
-            } catch (err3) {
-              throw err3;
-            }
-
-            expect(log.res.statusCode).to.eql(200);
-
-            done();
-          });
-        });
-    });
-
-    it("allows for custom request serializer", function (done) {
-      application = new Application({
-        controllers: {
-          dir: path.resolve(__dirname, "fixtures", "controllers")
-        },
-        database: {
-          connection,
-          models: { dir: path.resolve(__dirname, "fixtures/models") }
-        },
-        logging: {
-          serializers: {
-            req(req) {
-              return { url: req.url };
-            }
-          }
-        },
-        serializers: {
-          dir: path.resolve(__dirname, "fixtures", "serializers")
-        }
-      });
-
-      application.logger.addStream({
-        type: "stream",
-        stream
-      });
-      application.map(function () {
-        this.resource("user");
-      });
-      supertest(application.getApp())
-        .get("/users")
-        .end(function (err, res) {
-          if (err) { return done(err); }
-
-          expect(messages[0].req.url).to.eql("/users");
-          expect(messages[0].req).to.not.have.any.keys("httpVersion", "method");
-          done();
-        });
-    });
-
-    it("allows for custom response serializer", function (done) {
-      application = new Application({
-        controllers: {
-          dir: path.resolve(__dirname, "fixtures", "controllers")
-        },
-        database: {
-          connection,
-          models: { dir: path.resolve(__dirname, "fixtures/models") }
-        },
-        logging: {
-          serializers: {
-            res(res) {
-              return { statusCode: res.statusCode };
-            }
-          }
-        },
-        serializers: {
-          dir: path.resolve(__dirname, "fixtures", "serializers")
-        }
-      });
-
-      application.logger.addStream({
-        type: "stream",
-        stream
-      });
-      application.map(function () {
-        this.resource("user");
-      });
-      supertest(application.getApp())
-        .get("/users")
-        .end(function (err, res) {
-          if (err) { return done(err); }
-
-          expect(messages[0].res.statusCode).to.eql(200);
-          expect(messages[0].req).to.not.have.any.keys("headers");
-          done();
-        });
-    });
-  });
-
   describe("serializers", function () {
     it("uses JSONSerializer by default", function () {
       application = new Application({