wasm32-wasi -> wasm32-wasip1 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…32-wasip1. Added rustup target check to prepare.sh
bhelx
reviewed
Dec 7, 2024
|
|
||
| if ! (command_exists rustup); then | ||
| missing_deps=1 | ||
| echo "❌ rustup is missing. Check your rust installation." |
Contributor
There was a problem hiding this comment.
Note: not a blocker, but we should come back and add some links here about how to install rustup.
bhelx
reviewed
Dec 7, 2024
template/prepare.sh
Outdated
| echo "❌ rustup is missing. Check your rust installation." | ||
| echo "" | ||
| elif ! (rustup target list --installed | grep -q '^wasm32-wasip1$'); then | ||
| if ! (rustup target add wasm32-wasip1); then |
Contributor
There was a problem hiding this comment.
Also not a blocker, but we should install the unknown target as well
Contributor
Author
No prob! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the default target from deprecated wasm32-wasi target to wasm32-wasip1. Added rustup target check to prepare.sh